Mercurial > pidgin.yaz
view pidgin/pidgin.h @ 23995:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Sep 2008 18:04:29 +0000 |
parents | b5e35cce4f85 |
children | 17b840986607 |
line wrap: on
line source
/** * @file pidgin.h UI definitions and includes * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ /* #warning ***pidgin*** */ #ifndef _PIDGIN_H_ #define _PIDGIN_H_ #include <gtk/gtk.h> #ifdef GDK_WINDOWING_X11 # include <gdk/gdkx.h> #endif #ifdef _WIN32 # include "gtkwin32dep.h" #endif /** * Our UI's identifier. */ /* leave this as gtk-gaim until we have a decent way to migrate UI-prefs */ #define PIDGIN_UI "gtk-gaim" /* change this only when we have a sane upgrade path for old prefs */ #define PIDGIN_PREFS_ROOT "/pidgin" /* Translators may want to transliterate the name. It is not to be translated. */ #define PIDGIN_NAME _("Pidgin") #ifndef _WIN32 # define PIDGIN_ALERT_TITLE "" #else # define PIDGIN_ALERT_TITLE PIDGIN_NAME #endif /* * This is backwards-compatibility code for older versions of GTK+ (< 2.4.x) * It defines the new wrap behavior (unknown in earlier versions) * as the old (slightly buggy) wrap behavior. * It also includes our back-ported GtkExpander */ /** @cond */ #if (!GTK_CHECK_VERSION(2,4,0)) # define GTK_WRAP_WORD_CHAR GTK_WRAP_WORD # include "gtkexpander.h" #endif /** @endcond */ /* * We include the sources for GtkComboBox and GtkCellView because * they don't exist in older versions of GTK+, and we use them * in a few places. */ #if !GTK_CHECK_VERSION(2,6,0) # include "gtkcellview.h" # include "gtkcellviewmenuitem.h" # include "pidgincombobox.h" # if !GTK_CHECK_VERSION(2,4,0) # include "gtkcelllayout.h" # endif /* Less than GTK+ 2.4 */ #endif /* Less than GTK+ 2.6 */ /* * Spacings between components, as defined by the * GNOME Human Interface Guidelines. */ #define PIDGIN_HIG_CAT_SPACE 18 #define PIDGIN_HIG_BORDER 12 #define PIDGIN_HIG_BOX_SPACE 6 /* * See GNOME bug #307304 for some discussion about the invisible * character. 0x25cf is a good choice, too. */ #define PIDGIN_INVISIBLE_CHAR (gunichar)0x2022 #endif /* _PIDGIN_H_ */