Mercurial > pidgin.yaz
view pidgin/win32/untar.h @ 23995:85bed17fe5c1
The variable we use to keep track of the watcher of the ssl connection
should be unsigned. This isn't really a problem in Pidgin, where we
use glib's mainloop and GIOChannels because glib starts assigning the
handle IDs sequentially starting from 1.
But if an eventloop implementation ever returns a handle ID greater
than the largest possible signed integer (2,147,483,647) then we
won't be able to remove the watcher because purple_ssl_close() in
sslconn.c only removes it if inpa > 0, and since it interprets inpa
as a signed value then handles over 2,147,483,647 appear as negative
numbers.
I stumbled upon this when playing around with libevent, which can
use epoll. My implementation generated a random handle ID which
was sometimes greater than 2,147,483,647.
I don't believe this breaks binary compatibility. And I don't think
it breaks source compatibility, but I guess it might depend on what
compiler you're using.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 04 Sep 2008 18:04:29 +0000 |
parents | 322b92e28005 |
children | 5876584828e8 |
line wrap: on
line source
/* * untar.h * * Author: Herman Bloggs <hermanator12002@yahoo.com> * Date: April, 2003 * Description: untar.c header */ #ifndef _UNTAR_H_ #define _UNTAR_H_ #ifdef __cplusplus extern "C" { #endif /* __cplusplus */ typedef enum _untar_opt { UNTAR_LISTING = (1 << 0), UNTAR_QUIET = (1 << 1), UNTAR_VERBOSE = (1 << 2), UNTAR_FORCE = (1 << 3), UNTAR_ABSPATH = (1 << 4), UNTAR_CONVERT = (1 << 5) } untar_opt; int untar(const char *filename, const char *destdir, untar_opt options); #ifdef __cplusplus } #endif /* __cplusplus */ #endif