Mercurial > pidgin.yaz
view README.MTN @ 30009:8d4bed3021dc
Fix some problems in the oscar code that deals with channel 2 icbms.
Specifically related to rtf messages and sent as ICQ server relay.
Introduced in 1431506710bed6b8f0c837b670ee314b1692990e in the
im.pidgin.cpw.rekkanoryo.icqxstatus branch
* memleak fix: We weren't freeing rtfmsg
* remote crash fix: We always check args->info.rtfmsg.rtfmsg and try to
convert it to UTF-8. However, args->info.rtfmsg is a part of a union
and is only set/valid when args->type is OSCAR_CAPABILITY_ICQSERVERRELAY
So channel 2 icbms of other types (like chat invites, for example) tend
to cause a crash.
* possibly printing invalid utf-8: if we could not convert rtfmsg to utf8,
and the original rtfmsg failed to validate as utf8, then we tried to
write the message to the im window anyway. But that's clearly not a
good idea.
Really glad I happened to find that remote crash before we released--dealing
with security problems is such a pain.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 18 Mar 2010 07:55:17 +0000 |
parents | e0bcb8cfda74 |
children |
line wrap: on
line source
If you plan to use Pidgin, Finch and libpurple from our Monotone repository, PLEASE read this message in its entirety! Pidgin, Finch, and libpurple are a fast-moving project with a somewhat regular release schedule. Due to the rate of development, the code in our Monotone repository undergoes frequent bursts of massive changes, often leaving behind brokenness and partial functionality while the responsible developers rewrite some portion of code or seek to add new features. What this all boils down to is that the code in our Monotone repository _WILL_ sometimes be broken. Because of this, we ask that users who are not interested in personally tracking down bugs and fixing them (without a lot of assistance from the developers!) use only released versions. Since releases will be made often, this should not prevent anyone from using the newest, shiniest features -- but it will prevent users from having to deal with ugly development bugs that we already know about but haven't gotten around to fixing. If you are interested in hacking on Pidgin, Finch, and/or libpurple, please check out the information available at: http://developer.pidgin.im By far the best documentation, however, is the documented code. If you have doxygen, you can run "make docs" in the toplevel directory to generate pretty documentation. Otherwise (or even if you do!), the header files for each subsystem contain documentation for the functions they contain. For instance, conversation.h contains documentation for the entire purple_conversation_* API, and account.h contains documentation for the purple_account_* API. If you have questions, please feel free to contact the Pidgin, Finch, and libpurple developers by email at devel@pidgin.im or on IRC at irc.freenode.net in #pidgin. Please do as much homework as you can before contacting us; the more you know about your question, the faster and more effectively we can help! Patches should be posted as Trac tickets at: http://developer.pidgin.im