Mercurial > pidgin.yaz
view doc/ui-ops.dox @ 30009:8d4bed3021dc
Fix some problems in the oscar code that deals with channel 2 icbms.
Specifically related to rtf messages and sent as ICQ server relay.
Introduced in 1431506710bed6b8f0c837b670ee314b1692990e in the
im.pidgin.cpw.rekkanoryo.icqxstatus branch
* memleak fix: We weren't freeing rtfmsg
* remote crash fix: We always check args->info.rtfmsg.rtfmsg and try to
convert it to UTF-8. However, args->info.rtfmsg is a part of a union
and is only set/valid when args->type is OSCAR_CAPABILITY_ICQSERVERRELAY
So channel 2 icbms of other types (like chat invites, for example) tend
to cause a crash.
* possibly printing invalid utf-8: if we could not convert rtfmsg to utf8,
and the original rtfmsg failed to validate as utf8, then we tried to
write the message to the im window anyway. But that's clearly not a
good idea.
Really glad I happened to find that remote crash before we released--dealing
with security problems is such a pain.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Thu, 18 Mar 2010 07:55:17 +0000 |
parents | e3bf822c19c8 |
children |
line wrap: on
line source
/** @page ui-ops UiOps structures When implementing a UI for libpurple, you need to fill in various UiOps structures: - #PurpleAccountUiOps - #PurpleBlistUiOps - #PurpleConnectionUiOps - #PurpleConversationUiOps - #PurpleCoreUiOps - #PurpleDebugUiOps - #PurpleDnsQueryUiOps - #PurpleEventLoopUiOps (without this, nothing will work and you will cry) - #PurpleIdleUiOps - #PurpleNotifyUiOps - #PurplePrivacyUiOps - #PurpleRequestUiOps - #PurpleRoomlistUiOps - #PurpleSoundUiOps - #PurpleWhiteboardUiOps - #PurpleXferUiOps */ // vim: ft=c.doxygen