Mercurial > pidgin.yaz
view AUTHORS @ 31712:8fc25b77295a
Hopefully fixes #13298, the bug about not being able to add MSN buddies.
Here's what I think is happening:
1. Before we add the buddy we issue an FQY request to ask the server what
network the username is for (either normal MSN or Yahoo)
2. When we get the response we add the buddy to our buddy list with the
network ID given to us by the server
3. For some reason the server is now returning a network ID of 0 ("unknown")
instead of 1 ("normal MSN") for normal passport buddies, and we bail out
when we encounter this. QuLogic thinks the server used to return 1 in
this case.
My change is to just not bail out if the FQY response has network ID 0.
Instead of treat 0 as 1 and continue with the add. It looks like our
SOAP request to add the buddy to our address book will fail a big further
down the road if the buddy doesn't exist--so we're still protecting
against that.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 28 Feb 2011 08:26:40 +0000 |
parents | c4d512212ae2 |
children | 81a2ec76c285 |
line wrap: on
line source
Pidgin and Finch: The Pimpin' Penguin IM Clients That're Good for the Soul ========================================================================== For a complete list of all contributors, see the COPYRIGHT file. We've got an IRC room now too, #pidgin on irc.freenode.net. Come check us out. Current Developers: ------------------ Daniel 'datallah' Atallah - Developer Paul 'darkrain42' Aurich - Developer John 'rekkanoryo' Bailey - Developer Ethan 'Paco-Paco' Blanton - Developer Thomas Butter - Developer Ka-Hing Cheung - Developer Sadrul Habib Chowdhury - Developer Mark 'KingAnt' Doliner - Developer Sean Egan - Developer Casey Harkins - Developer Ivan Komarov - Developer Gary 'grim' Kramlich - Developer Richard 'rlaager' Laager - Developer Sulabh 'sulabh_m' Mahajan - Developer Richard 'wabz' Nelson - Developer Christopher 'siege' O'Brien - Developer Bartosz Oler - Developer Etan 'deryni' Reisner - Developer Tim 'marv' Ringenbach - Developer Michael 'Maiku' Ruprecht - Developer, voice and video Elliott 'QuLogic' Sales de Andrade - Developer Luke 'LSchiere' Schierer - Support Megan 'Cae' Schneider - support/QA Evan Schoenberg - Developer Kevin 'SimGuy' Stange - Developer & Webmaster Will 'resiak' Thompson - Developer Stu 'nosnilmot' Tomlinson - Developer Nathan 'faceprint' Walp - Developer Crazy Patch Writers: ------------------- Marcus 'malu' Lundblad Dennis 'EvilDennisR' Ristuccia Peter 'Fmoo' Ruibal Gabriel 'Nix' Schulhof Jorge 'Masca' Villaseñor Retired Developers: ------------------ Herman Bloggs - Win32 Port Jim Duchek <jim@linuxpimps.com> - maintainer Rob Flynn <gaim@robflynn.com> - maintainer Adam Fritzler - libfaim maintainer Christian 'ChipX86' Hammond - Developer & Webmaster Syd Logan - hacker and designated driver [lazy bum] Jim Seymour - XMPP developer Mark Spencer <markster@marko.net> - original author Eric Warmenhoven <eric@warmenhoven.org> - lead developer Retired Crazy Patch Writers: --------------------------- Felipe 'shx' Contreras Decklin Foster Peter 'Bleeter' Lawler Robert 'Robot101' McQueen Benjamin Miller Artists: ------- Hylke Bons - Icons Other Contributions: ------------------- Much thanks to Evan Martin <martine@cs.washington.edu> for writing GtkSpell <http://gtkspell.sourceforge.net> responsible for the "Highlight misspelled words" feature and for gtk-nativewin <http://bunny.darktech.org/cvs/gtk-nativewin/> the default GTK+-2.0 engine originally used in our win32 port. ** ORIGINAL LOGO DESIGNED BY: Naru Sundar ** Peter Teichiman <peter@helixcode.com> Larry Ewing Jeramey A. Crawford Thanks to these boys. Peter and Larry managed to stomp out a large list of Mem Leaks. Jeramey found the remaining onees and pointed me to those. Props to the boys at Helix Code. Thanks guys. Nathan Walp A healthy amount of patches for the Jabber plugin Neil Sanchala Wrote most of the Zephyr plugin Arkadiusz Miskiewicz Wrote the Gadu-Gadu plugin David Prater <IM: dRaven43> draven@tcsx.net Log and Colour Button Images Sébastien Carpe <IM: Seb Carpe> Base HTTP Proxy Support Ari Pollak <IM: Ari Pollak> compwiz.dhs.org Resize conversation window patch Decklin Foster Many GUI improvements, other nifty additions and fixes David <IM: CrazyDavy> The neato-bigger text box S D Erle Writing a cool perl script to translate WinAIM lists to gaim BMiller A good collection of stuff. %n for away messages, import winaim lists, pic/text/pic+text for buttons, among others Lance Rocker Improved HTML formatting in logs, plus lots of debugging on *BSD. ergofobe: GNOME Url handler patch Justin M. Ward <justin@yossman.net>: Alphabetical Away Messages patch G. Sumner Hayes <IM: SumnerFool> Security Patches Brian Ryner for a little make file patch :) Ryan C. Gordon - I still think you look like Silent Bob. Elliot Tobin <elliot@bha.udel.edu> Thanks to Jeroen van der Vegt for the initial smiley plugin and images. The OpenQ Team Wrote the QQ plugin (see AUTHORS in the qq directory)