Mercurial > pidgin.yaz
view pidgin/gtkconvwin.h @ 31712:8fc25b77295a
Hopefully fixes #13298, the bug about not being able to add MSN buddies.
Here's what I think is happening:
1. Before we add the buddy we issue an FQY request to ask the server what
network the username is for (either normal MSN or Yahoo)
2. When we get the response we add the buddy to our buddy list with the
network ID given to us by the server
3. For some reason the server is now returning a network ID of 0 ("unknown")
instead of 1 ("normal MSN") for normal passport buddies, and we bail out
when we encounter this. QuLogic thinks the server used to return 1 in
this case.
My change is to just not bail out if the FQY response has network ID 0.
Instead of treat 0 as 1 and continue with the add. It looks like our
SOAP request to add the buddy to our address book will fail a big further
down the road if the buddy doesn't exist--so we're still protecting
against that.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 28 Feb 2011 08:26:40 +0000 |
parents | 5f80ccce8003 |
children | ae24e54a5014 4f445c48581a |
line wrap: on
line source
/** * @file gtkconvwin.h GTK+ Conversation Window API * @ingroup pidgin */ /* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PIDGIN_CONVERSATION_WINDOW_H_ #define _PIDGIN_CONVERSATION_WINDOW_H_ typedef struct _PidginWindow PidginWindow; /************************************************************************** * @name Structures **************************************************************************/ /*@{*/ /** * A GTK+ representation of a graphical window containing one or more * conversations. */ struct _PidginWindow { GtkWidget *window; /**< The window. */ GtkWidget *notebook; /**< The notebook of conversations. */ GList *gtkconvs; struct { GtkWidget *menubar; GtkWidget *view_log; GtkWidget *send_file; GtkWidget *add_pounce; GtkWidget *get_info; GtkWidget *invite; GtkWidget *alias; GtkWidget *block; GtkWidget *unblock; GtkWidget *add; GtkWidget *remove; GtkWidget *insert_link; GtkWidget *insert_image; GtkWidget *logging; GtkWidget *sounds; GtkWidget *show_formatting_toolbar; GtkWidget *show_timestamps; GtkWidget *show_icon; GtkWidget *send_to; GtkWidget *tray; GtkWidget *typing_icon; GtkItemFactory *item_factory; } menu; struct { GtkWidget *search; } dialogs; /* Tab dragging stuff. */ gboolean in_drag; gboolean in_predrag; gint drag_tab; gint drag_min_x, drag_max_x, drag_min_y, drag_max_y; gint drag_motion_signal; gint drag_leave_signal; /* Media menu options. */ GtkWidget *audio_call; GtkWidget *video_call; GtkWidget *audio_video_call; }; /*@}*/ /************************************************************************** * @name GTK+ Conversation Window API **************************************************************************/ /*@{*/ PidginWindow * pidgin_conv_window_new(void); void pidgin_conv_window_destroy(PidginWindow *win); GList *pidgin_conv_windows_get_list(void); void pidgin_conv_window_show(PidginWindow *win); void pidgin_conv_window_hide(PidginWindow *win); void pidgin_conv_window_raise(PidginWindow *win); void pidgin_conv_window_switch_gtkconv(PidginWindow *win, PidginConversation *gtkconv); void pidgin_conv_window_add_gtkconv(PidginWindow *win, PidginConversation *gtkconv); void pidgin_conv_window_remove_gtkconv(PidginWindow *win, PidginConversation *gtkconv); PidginConversation *pidgin_conv_window_get_gtkconv_at_index(const PidginWindow *win, int index); PidginConversation *pidgin_conv_window_get_active_gtkconv(const PidginWindow *win); PurpleConversation *pidgin_conv_window_get_active_conversation(const PidginWindow *win); gboolean pidgin_conv_window_is_active_conversation(const PurpleConversation *conv); gboolean pidgin_conv_window_has_focus(PidginWindow *win); PidginWindow *pidgin_conv_window_get_at_xy(int x, int y); GList *pidgin_conv_window_get_gtkconvs(PidginWindow *win); guint pidgin_conv_window_get_gtkconv_count(PidginWindow *win); PidginWindow *pidgin_conv_window_first_with_type(PurpleConversationType type); PidginWindow *pidgin_conv_window_last_with_type(PurpleConversationType type); /*@}*/ /************************************************************************** * @name GTK+ Conversation Placement API **************************************************************************/ /*@{*/ typedef void (*PidginConvPlacementFunc)(PidginConversation *); GList *pidgin_conv_placement_get_options(void); void pidgin_conv_placement_add_fnc(const char *id, const char *name, PidginConvPlacementFunc fnc); void pidgin_conv_placement_remove_fnc(const char *id); const char *pidgin_conv_placement_get_name(const char *id); PidginConvPlacementFunc pidgin_conv_placement_get_fnc(const char *id); void pidgin_conv_placement_set_current_func(PidginConvPlacementFunc func); PidginConvPlacementFunc pidgin_conv_placement_get_current_func(void); void pidgin_conv_placement_place(PidginConversation *gtkconv); /*@}*/ #endif /* _PIDGIN_CONVERSATION_WINDOW_H_ */