Mercurial > pidgin.yaz
view src/gtkprefs.h @ 12498:a2de852981c1
[gaim-migrate @ 14810]
SF Patch #1380806 from charkins
"leave docklet loaded when notification area is not present"
"From the summary, this sounds weird, but I think its
better behavior. This really only effects some odd
corner cases. The existing behavior is that the docklet
plugin unloads itself after 10 seconds if the tray icon
isn't created. The behavior with this patch is that
there is a 3 second timeout (this is necessary to avoid
race condition when restoring the gtkblist's visibility
state on startup). After this timeout, the docklet
plugin stays loaded waiting for a notification to
appear, but is essentially non-functional.
In the typical scenario, this patch doesn't effect the
behavior. Here are some examples of where it does matter:
1) If gaim is closed with the buddy list hidden to the
docklet, then gaim is started again without a
notification area, the buddy list doesn't show up for
10 seconds (the time it takes for the docklet to
timeout). This patch would reduce this to 3 seconds.
2) If the user removes the notification area from their
panel, maybe to remove it from one panel and add it to
a different panel, but doesn't add a new one back
within 10 seconds, the current behavior would cause the
docklet plugin to be unloaded. With this patch, the
tray icon would automatically be added to the new
notification area when it becomes available.
3) The gnome-panel dies and is not restarted within 10
seconds. Similar to #2. (There was a bug filed for
this, but can't find it right now).
My main concern was that it could be confusing to the
user if they enable the docklet plugin, then 10 seconds
later it gets disabled without any notification. This
patch doesn't add any notification, but leaves the
plugin running so it will automatically use a
notification area when one becomes available.
I also removed an unused parameter from
docklet_remove() and changed the plugin description
slightly to reflect the change in queuing/notification.
Not sure how clear this is, so bug me on #gaim if you
have any questions. --charkins"
I made a few changes to this patch, but nothing terribly significant...
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Fri, 16 Dec 2005 09:16:14 +0000 |
parents | fc464a0abccc |
children |
line wrap: on
line source
/** * @file gtkprefs.h GTK+ Preferences * @ingroup gtkui * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #ifndef _GAIM_GTKPREFS_H_ #define _GAIM_GTKPREFS_H_ #include "prefs.h" /** * Initializes all UI-specific preferences. */ void gaim_gtk_prefs_init(void); /** * Shows the preferences dialog. */ void gaim_gtk_prefs_show(void); /** * Add a new checkbox for a boolean preference * * @param title The text to be displayed as the checkbox label * @param key The key of the gaim bool pref that will be represented by the checkbox * @param page The page to which the new checkbox will be added */ GtkWidget *gaim_gtk_prefs_checkbox(const char *title, const char *key, GtkWidget *page); /** * Add a new spin button representing an int preference * * @param page The page to which the spin button will be added * @param title The text to be displayed as the spin button label * @param key The key of the int pref that will be represented by the spin button * @param min The minimum value of the spin button * @param max The maximum value of the spin button * @param sg If not NULL, the size group to which the spin button will be added * @return An hbox containing both the label and the spinner. Can be * used to set the widgets to sensitive or insensitive based on the * value of a checkbox. */ GtkWidget *gaim_gtk_prefs_labeled_spin_button(GtkWidget *page, const gchar *title, const char *key, int min, int max, GtkSizeGroup *sg); /** * Add a new entry representing a string preference * * @param page The page to which the entry will be added * @param title The text to be displayed as the entry label * @param key The key of the string pref that will be represented by the entry * @param sg If not NULL, the size group to which the entry will be added * * @return An hbox containing both the label and the entry. Can be used to set * the widgets to sensitive or insensitive based on the value of a * checkbox. */ GtkWidget *gaim_gtk_prefs_labeled_entry(GtkWidget *page, const gchar *title, const char *key, GtkSizeGroup *sg); /** * Add a new dropdown representing a preference of the specified type * * @param page The page to which the dropdown will be added * @param title The text to be displayed as the dropdown label * @param type The type of preference to be stored in the generated dropdown * @param key The key of the pref that will be represented by the dropdown * @param ... The choices to be added to the dropdown, choices should be * paired as label/value */ GtkWidget *gaim_gtk_prefs_dropdown(GtkWidget *page, const gchar *title, GaimPrefType type, const char *key, ...); /** * Add a new dropdown representing a preference of the specified type * * @param page The page to which the dropdown will be added * @param title The text to be displayed as the dropdown label * @param type The type of preference to be stored in the dropdown * @param key The key of the pref that will be represented by the dropdown * @param menuitems The choices to be added to the dropdown, choices should * be paired as label/value */ GtkWidget *gaim_gtk_prefs_dropdown_from_list(GtkWidget *page, const gchar * title, GaimPrefType type, const char *key, GList *menuitems); /** * Rename legacy prefs and delete some that no longer exist. */ void gaim_gtk_prefs_update_old(void); #endif /* _GAIM_GTKPREFS_H_ */