Mercurial > pidgin.yaz
view src/protocols/novell/nmrequest.c @ 11261:b53606580f68
[gaim-migrate @ 13439]
Patch #1226486 from Levi Bard
Fixes bug #1224178
If you change the topic in a chat room and that topic change is rejected, the
topic field is wrong -- it shows the new topic even thought it didn't get set.
This patch resets the GUI's topic immediately when you hit enter. Then, if the
topic change is successful, the server will echo the topic change back to us
and we'll update the GUI to the new topic.
The only question is, does the server always echo the topic back to us? From the
core's point of view, I'm ready to assume yes. It's the case for both IRC and
Jabber*. If someone could test changing a topic in SILC or Zephyr, that'd be
great. If servers using those protocols do not echo the topic back, the prpl
will have to fake it as appropriate.
* I didn't actually test on Jabber, but Nathan said the server will echo the
topic change back. If it's broken, let me know.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 14 Aug 2005 06:55:57 +0000 |
parents | d77537e8bfe5 |
children |
line wrap: on
line source
/* * nmrequest.c * * Copyright (c) 2004 Novell, Inc. All Rights Reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include "nmrequest.h" static int count = 0; struct _NMRequest { int trans_id; char *cmd; int gmt; gpointer data; gpointer user_define; nm_response_cb callback; int ref_count; NMERR_T ret_code; }; NMRequest *nm_create_request(const char *cmd, int trans_id, int gmt, nm_response_cb cb, gpointer resp_data, gpointer user_define) { NMRequest *req; if (cmd == NULL) return NULL; req = g_new0(NMRequest, 1); req->cmd = g_strdup(cmd); req->trans_id = trans_id; req->gmt = gmt; req->callback = cb; req->data = resp_data; req->user_define = user_define; req->ref_count = 1; gaim_debug_info("novell", "Creating NMRequest instance, total=%d\n", ++count); return req; } void nm_release_request(NMRequest * req) { if (req && (--req->ref_count == 0)) { if (req->cmd) g_free(req->cmd); g_free(req); gaim_debug_info("novell", "Releasing NMRequest instance, total=%d\n", --count); } } void nm_request_add_ref(NMRequest * req) { if (req) req->ref_count++; } void nm_request_set_callback(NMRequest * req, nm_response_cb callback) { if (req) req->callback = callback; } void nm_request_set_data(NMRequest * req, gpointer data) { if (req) req->data = data; } void nm_request_set_user_define(NMRequest * req, gpointer user_define) { if (req) req->user_define = user_define; } int nm_request_get_trans_id(NMRequest * req) { if (req) return req->trans_id; else return -1; } const char * nm_request_get_cmd(NMRequest * req) { if (req == NULL) return NULL; return req->cmd; } gpointer nm_request_get_data(NMRequest * req) { if (req == NULL) return NULL; return req->data; } gpointer nm_request_get_user_define(NMRequest * req) { if (req == NULL) return NULL; return req->user_define; } nm_response_cb nm_request_get_callback(NMRequest * req) { if (req == NULL) return NULL; return req->callback; } void nm_request_set_ret_code(NMRequest * req, NMERR_T rc) { if (req) req->ret_code = rc; } NMERR_T nm_request_get_ret_code(NMRequest * req) { if (req) return req->ret_code; else return (NMERR_T) - 1; }