Mercurial > pidgin.yaz
view src/stringref.c @ 11261:b53606580f68
[gaim-migrate @ 13439]
Patch #1226486 from Levi Bard
Fixes bug #1224178
If you change the topic in a chat room and that topic change is rejected, the
topic field is wrong -- it shows the new topic even thought it didn't get set.
This patch resets the GUI's topic immediately when you hit enter. Then, if the
topic change is successful, the server will echo the topic change back to us
and we'll update the GUI to the new topic.
The only question is, does the server always echo the topic back to us? From the
core's point of view, I'm ready to assume yes. It's the case for both IRC and
Jabber*. If someone could test changing a topic in SILC or Zephyr, that'd be
great. If servers using those protocols do not echo the topic back, the prpl
will have to fake it as appropriate.
* I didn't actually test on Jabber, but Nathan said the server will echo the
topic change back. If it's broken, let me know.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 14 Aug 2005 06:55:57 +0000 |
parents | ceb88c0a1abb |
children |
line wrap: on
line source
/** * @file stringref.c Reference-counted immutable strings * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include "internal.h" #include <string.h> #include <stdarg.h> #include "debug.h" #include "stringref.h" #define REFCOUNT(x) ((x) & 0x7fffffff) static GList *gclist = NULL; static void stringref_free(GaimStringref *stringref); static gboolean gs_idle_cb(gpointer data); GaimStringref *gaim_stringref_new(const char *value) { GaimStringref *newref; if (value == NULL) return NULL; newref = g_malloc(sizeof(GaimStringref) + strlen(value)); strcpy(newref->value, value); newref->ref = 1; return newref; } GaimStringref *gaim_stringref_new_noref(const char *value) { GaimStringref *newref; if (value == NULL) return NULL; newref = g_malloc(sizeof(GaimStringref) + strlen(value)); strcpy(newref->value, value); newref->ref = 0x80000000; if (gclist == NULL) g_idle_add(gs_idle_cb, NULL); gclist = g_list_prepend(gclist, newref); return newref; } GaimStringref *gaim_stringref_printf(const char *format, ...) { GaimStringref *newref; va_list ap; if (format == NULL) return NULL; va_start(ap, format); newref = g_malloc(sizeof(GaimStringref) + g_printf_string_upper_bound(format, ap)); vsprintf(newref->value, format, ap); va_end(ap); newref->ref = 1; return newref; } GaimStringref *gaim_stringref_ref(GaimStringref *stringref) { if (stringref == NULL) return NULL; stringref->ref++; return stringref; } void gaim_stringref_unref(GaimStringref *stringref) { if (stringref == NULL) return; if (REFCOUNT(--(stringref->ref)) == 0) { if (stringref->ref & 0x80000000) gclist = g_list_remove(gclist, stringref); stringref_free(stringref); } } const char *gaim_stringref_value(const GaimStringref *stringref) { return (stringref == NULL ? NULL : stringref->value); } int gaim_stringref_cmp(const GaimStringref *s1, const GaimStringref *s2) { return (s1 == s2 ? 0 : strcmp(gaim_stringref_value(s1), gaim_stringref_value(s2))); } size_t gaim_stringref_len(const GaimStringref *stringref) { return strlen(gaim_stringref_value(stringref)); } static void stringref_free(GaimStringref *stringref) { #ifdef DEBUG if (REFCOUNT(stringref->ref) != 0) { gaim_debug(GAIM_DEBUG_ERROR, "stringref", "Free of nonzero (%d) ref stringref!\n", REFCOUNT(stringref->ref)); return; } #endif /* DEBUG */ g_free(stringref); } static gboolean gs_idle_cb(gpointer data) { GaimStringref *ref; GList *del; while (gclist != NULL) { ref = gclist->data; if (REFCOUNT(ref->ref) == 0) { stringref_free(ref); } del = gclist; gclist = gclist->next; g_list_free_1(del); } return FALSE; }