view HACKING @ 24536:c457c635eb8f

Two functional changes here: 1. The default error case for unknown errors on yahoo now uses PURPLE_CONNECTION_ERROR_OTHER_ERROR instead of PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED. This change was made because it's logical. 2. The unknown yahoo error with error code "0" now uses PURPLE_CONNECTION_ERROR_NETWORK_ERROR instead of PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED. This change was made because this error doesn't seem to be fatal, and we want the account to be reconnected, but normally AUTHENTICATION_FAILED errors are fatal and should not be reconnected Specially this makes yahoo accounts auto-reconnect when we get the error "Unknown error number 0. Logging into the Yahoo! website may fix this." I know we think we fixed this with that change to send the timeout or keepalive much less often, but I'm still seeing a lot of disconnects for it and I have a strong suspicion that they're not actually fatal errors. Refs #5223

For information on hacking on Pidgin, Finch, or libpurple, see:
	http://developer.pidgin.im