Mercurial > pidgin.yaz
view COPYRIGHT @ 10039:cf02e7104706
[gaim-migrate @ 10998]
A patch from rian hunter (chrono86):
In src/protocols/oscar/oscar.c, in the function
gaim_plugin_oscar_convert_to_best_encoding. g_convert
is called multiple times. As its 5th argument g_convert
takes a gsize* (8 byte), yet the argument to
gaim_plugin_oscar_convert_to_best_encoding is a int* (4
byte).
On LP64 machines this can allow the int* to be
overwritten. This is especially bad on big endian
64-bit machines, causing the high 32-bits to be written
into the low 32-bits of the int.
This is a quick fix patch that lets g_convert deal with
a gsize* pointer instead, then casting the value at
gsize* to the value at the int*.
A real fix would be to fix the aim_sendimext_args
structure to have a gsize instead of an int (and all
functions that use the aim_sendimext_args struct), and
changing gaim_plugin_oscar_convert_to_best_encoding to
accept a gsize*. of course, this woudl promote glib2
dependence, so that's probably not the best thing to do.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Sat, 18 Sep 2004 23:17:18 +0000 |
parents | 1ececa0e7072 |
children | e2890a4585c0 |
line wrap: on
line source
Gaim Copyright (C) 1998-2004 by the following: If you have contributed to Gaim, you deserve to be on this list. Contact us (see: AUTHORS) and we'll add you. Daniel Atallah Paul Aurich Patrick Aussems Kevin Barry Curtis Beattie Dave Bell Brian Bernas Jonas Birmé Eric Blade Ethan Blanton Joshua Blanton Herman Bloggs David Blue Jason Boerner Graham Booker Craig Boston Chris Boyle Matt Brenneke Jeremy Brooks Philip Brown Sean Burke Cerulean Studios, LLC Jonathan Champ Ka-Hing Cheung Arturo Cisneros, Jr. Vincas Ciziunas Joe Clarke Todd Cohen Felipe Contreras Adam Cowell Jeramey Crawford Finlay Dobbie Mark Doliner Nuno Donato Jim Duchek Tom Dyas Marc E. Marc Etcheverry Andrew Echols Sean Egan <sean.egan@binghamton.edu> Nelson Elhage Ignacio J. Elia Brian Enigma Stefan Esser Larry Ewing Jesse Farmer Gavan Fantom (gavan) Rob Flynn <gaim@robflynn.com> Rob (rwf) Foehl Alan Ford Nathan Fredrickson Chris J. Friesen Free Software Foundation Decklin Foster Adam Fritzler Max G. François Gagné Evgueni V. Gavrilov Ignacy Gawedzki Michael Golden Ryan C. Gordon Christian Hammond Benjamin Herrenschmidt Andy Harrison G. Sumner Hayes Mike Heffner Casey Ho Iain Holmes Karsten Huneycutt Rian Hunter Henry Jen Akuke Kok Cole Kowalski Gary Kramlich Tero Kuusela Scott Lamb Dennis Lambe Jr. Joe LaPenna Daniel Larsson Peter Lawler Ho-seok Lee Moses Lei Ambrose C. Li Nicolas Lichtmaier Artem Litvinovich Syd Logan Uli Luckas Matthew Luckie Mike Lundy Brian Macke Paolo Maggi Willian T. Mahan John Matthews Ryan McCabe Kurt McKee Torrey McMahon Robert McQueen Robert Mibus Benjamin Miller Kevin Miller Paul Miller Arkadiusz Miskiewicz Andrew Molloy Novell Padraig O'Briain Christopher (siege) O'Brien Jon Oberheide Gudmundur Bjarni Olafsson Nathan (pianocomp81) Owens Matt Pandina Ricardo Fernandez Pascual Havoc Pennington Eduardo Pérez Ari Pollak Robey Pointer Nathan Poznick Brent Priddy Federicco Mena Quintero Yosef Radchenko David Raeman Etan Reisner Kristian Rietveld Pekka Riikonen Tim Ringenbach Rhett Robinson Luciano Miguel Ferreira Rocha Andrew Rodland Arvind Samptur Sam S. Tom Samstag Neil Sanchala Carsten Schaar Luke Schierer Evan Schoenberg Torrey Searle Don Seiler Leonardo Serra Jim Seymour Joe Shaw John Silvestri Alex Smith David Smock Phil Snowberger Eddie (tr1sk) Sohn Mark Spencer <markster@marko.net> Lex Spoon Kevin Stange David Stoddard Sun Microsystems Mårten (fursten) Svantesson Robert T. Brian Tarricone Peter Teichman Philip Tellis Arun A. Tharuvai Douglas (douglaswth) Thrift Stu Tomlinson Bill Tompkins Tom Tromey Chris Toshok Junichi Uekawa István Váradi David Vermeille Bjoern Voigt Nathan Walp Eric Warmenhoven Andrew Wellington Dave West Andrew Whewell Dan Willemsen Jason Willis Matt Wilson Justin Wood Ximian Jared Yanovich Timmy Yee Nickolai Zeldovich Marco Ziech Jaroen Zwartepoorte