Mercurial > pidgin.yaz
view libpurple/purple-client.c @ 22393:dfe4a3e3336a
serv_got_joined_chat() emits "chat-joined" but it also calls
purple_conversation_new() which emits "conversation-created", so attaching
to both signals would make create_conv and attach_signals to be called twice,
leaking the list of signal ids:
==30871== 67 (43 direct, 24 indirect) bytes in 3 blocks are definitely lost in loss record 94 of 265
==30871== at 0x4006A6E: malloc (vg_replace_malloc.c:207)
==30871== by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0xA31B3A: g_slice_alloc (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0xA32D9A: g_slist_append (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0x4F1CA4A: attach_signals (notify.c:321)
==30871== by 0x4F1CDCA: conv_created (notify.c:388)
Credit goes to Andrew Gaul for sending me this valgrind trace, blame me if
this breaks anything.
author | Ka-Hing Cheung <khc@hxbc.us> |
---|---|
date | Mon, 03 Mar 2008 07:03:54 +0000 |
parents | d4464c354346 |
children | 48d09d62912e |
line wrap: on
line source
#define DBUS_API_SUBJECT_TO_CHANGE #include <dbus/dbus-glib.h> #include <stdio.h> #include <stdlib.h> #include "dbus-purple.h" #include "purple-client.h" static DBusGConnection *bus; static DBusGProxy *purple_proxy; static GList *garray_int_to_glist(GArray *array) { GList *list = NULL; int i; for (i = 0; i < array->len; i++) list = g_list_append(list, GINT_TO_POINTER(g_array_index(array,gint,i))); g_array_free(array, TRUE); return list; } static GSList *garray_int_to_gslist(GArray *array) { GSList *list = NULL; int i; for (i = 0; i < array->len; i++) list = g_slist_append(list, GINT_TO_POINTER(g_array_index(array,gint,i))); g_array_free(array, TRUE); return list; } #include "purple-client-bindings.c" static void lose(const char *fmt, ...) G_GNUC_NORETURN G_GNUC_PRINTF (1, 2); static void lose_gerror(const char *prefix, GError *error) G_GNUC_NORETURN; static void lose(const char *str, ...) { va_list args; va_start(args, str); vfprintf(stderr, str, args); fputc('\n', stderr); va_end(args); exit(1); } static void lose_gerror(const char *prefix, GError *error) { lose("%s: %s", prefix, error->message); } void purple_init(void) { GError *error = NULL; g_type_init (); bus = dbus_g_bus_get (DBUS_BUS_SESSION, &error); if (!bus) lose_gerror ("Couldn't connect to session bus", error); purple_proxy = dbus_g_proxy_new_for_name (bus, DBUS_SERVICE_PURPLE, DBUS_PATH_PURPLE, DBUS_INTERFACE_PURPLE); if (!purple_proxy) lose_gerror ("Couldn't connect to the Purple Service", error); }