Mercurial > pidgin.yaz
view pidgin/gtkdocklet.h @ 22393:dfe4a3e3336a
serv_got_joined_chat() emits "chat-joined" but it also calls
purple_conversation_new() which emits "conversation-created", so attaching
to both signals would make create_conv and attach_signals to be called twice,
leaking the list of signal ids:
==30871== 67 (43 direct, 24 indirect) bytes in 3 blocks are definitely lost in loss record 94 of 265
==30871== at 0x4006A6E: malloc (vg_replace_malloc.c:207)
==30871== by 0xA1CAF5: g_malloc (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0xA31B3A: g_slice_alloc (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0xA32D9A: g_slist_append (in /lib/libglib-2.0.so.0.1400.6)
==30871== by 0x4F1CA4A: attach_signals (notify.c:321)
==30871== by 0x4F1CDCA: conv_created (notify.c:388)
Credit goes to Andrew Gaul for sending me this valgrind trace, blame me if
this breaks anything.
author | Ka-Hing Cheung <khc@hxbc.us> |
---|---|
date | Mon, 03 Mar 2008 07:03:54 +0000 |
parents | d3e0eb05ac94 |
children | 584063555949 |
line wrap: on
line source
/* * System tray icon (aka docklet) plugin for Purple * * Copyright (C) 2002-3 Robert McQueen <robot101@debian.org> * Copyright (C) 2003 Herman Bloggs <hermanator12002@yahoo.com> * Inspired by a similar plugin by: * John (J5) Palmieri <johnp@martianrock.com> * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of the * License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA * 02111-1301, USA. */ #ifndef _GTKDOCKLET_H_ #define _GTKDOCKLET_H_ #include "status.h" struct docklet_ui_ops { void (*create)(void); void (*destroy)(void); void (*update_icon)(PurpleStatusPrimitive, gboolean, gboolean); void (*blank_icon)(void); void (*set_tooltip)(gchar *); GtkMenuPositionFunc position_menu; }; /* functions in gtkdocklet.c */ void pidgin_docklet_update_icon(void); void pidgin_docklet_clicked(int); void pidgin_docklet_embedded(void); void pidgin_docklet_remove(void); void pidgin_docklet_set_ui_ops(struct docklet_ui_ops *); void pidgin_docklet_unload(void); void pidgin_docklet_init(void); void pidgin_docklet_uninit(void); void*pidgin_docklet_get_handle(void); /* function in gtkdocklet-{x11,win32}.c */ void docklet_ui_init(void); #endif /* _GTKDOCKLET_H_ */