Mercurial > pidgin.yaz
view libgaim/dbus-useful.c @ 15298:f08b43af6791
[gaim-migrate @ 18088]
We've seen a crash in which a NULL circbuffer was passed to gaim_circ_buffer_append() from flap_connection_send_byte_stream().
(flap_connection_send_byte_stream() was somehow called after flap_connection_close() - perhaps a result of the rate limiting queuing code?)
In any case, circbuffer should use g_return_if_fail() and g_return_val_if_fail() to throw warnings in this condition rather than crashing on a NULL pointer access. Added such checks at the top of the relevant functions.
committer: Tailor Script <tailor@pidgin.im>
author | Evan Schoenberg <evan.s@dreskin.net> |
---|---|
date | Mon, 08 Jan 2007 15:01:06 +0000 |
parents | 60b1bc8dbf37 |
children |
line wrap: on
line source
#include <string.h> #include <glib.h> #include "dbus-useful.h" #include "conversation.h" #include "util.h" GaimAccount * gaim_accounts_find_ext(const char *name, const char *protocol_id, gboolean (*account_test)(const GaimAccount *account)) { GaimAccount *result = NULL; GList *l; char *who; if (name) who = g_strdup(gaim_normalize(NULL, name)); else who = NULL; for (l = gaim_accounts_get_all(); l != NULL; l = l->next) { GaimAccount *account = (GaimAccount *)l->data; if (who && strcmp(gaim_normalize(NULL, gaim_account_get_username(account)), who)) continue; if (protocol_id && strcmp(account->protocol_id, protocol_id)) continue; if (account_test && !account_test(account)) continue; result = account; break; } g_free(who); return result; } GaimAccount *gaim_accounts_find_any(const char *name, const char *protocol) { return gaim_accounts_find_ext(name, protocol, NULL); } GaimAccount *gaim_accounts_find_connected(const char *name, const char *protocol) { return gaim_accounts_find_ext(name, protocol, gaim_account_is_connected); }