Mercurial > pidgin.yaz
view src/network.c @ 9240:f1d87ab17e41
[gaim-migrate @ 10039]
wing writes:
While working on patch 967849, found that there are a
few problems with current Content-Length handling:
1. parse_content_len uses a single sscanf on data.
However, data (the response headers) would begin with
the http status, not the Content-Length
2. data is not nul-terminated, but sscanf assumes a
nul-terminated string. This could (though very
unlikely) be unpredictable if input is malformed.
3. if gaim_url_fetch succeeds in extracting the
Content-Length from the response headers, it will
silently discard all the data after they have been
read, because it does not keep track of whether the
specified number of bytes has been read (The "else"
case that corresponds to this situation is an empty block.)
The attached patch corrects the above problems, though
the patch is still technically not correct, since
Content-Length theoretically should be matched
case-insensitively.
He then revised the patch and wrote:
More problems, unrelated to content-length handling, have
been discovered:
1. Gaim's http/1.1 support is broken; http/1.1 clients are
_required_ to be able to decode the "chunked" transfer
encoding, but gaim cannot do it. Since the difference
between gaim's http 1.0 and 1.1 support is only to send the
Host header, which is not forbidden in http 1.0, I have
changed gaim's http 1.0 behaviour to also send the Host
header. This is required for Yahoo Japan "avatar" support.
(The server requires a Host header but sends the image in
the chunked encoding, which gaim cannot decode.)
2. User-Agent should not be quoted
committer: Tailor Script <tailor@pidgin.im>
author | Tim Ringenbach <marv@pidgin.im> |
---|---|
date | Wed, 09 Jun 2004 01:24:47 +0000 (2004-06-09) |
parents | e40f9afd420e |
children | ad93d76666dd |
line wrap: on
line source
/** * @file network.c Network Implementation * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "internal.h" #include "debug.h" #include "account.h" #include "network.h" #include "prefs.h" const unsigned char * gaim_network_ip_atoi(const char *ip) { static unsigned char ret[4]; gchar *delimiter = "."; gchar **split; int i; g_return_val_if_fail(ip != NULL, NULL); split = g_strsplit(ip, delimiter, 4); for (i = 0; split[i] != NULL; i++) ret[i] = atoi(split[i]); g_strfreev(split); /* i should always be 4 */ if (i != 4) return NULL; return ret; } void gaim_network_set_public_ip(const char *ip) { g_return_if_fail(ip != NULL); /* XXX - Ensure the IP address is valid */ gaim_prefs_set_string("/core/network/public_ip", ip); } const char * gaim_network_get_public_ip(void) { const char *ip; ip = gaim_prefs_get_string("/core/network/public_ip"); if (ip == NULL || *ip == '\0') return NULL; return ip; } static const char * gaim_network_get_local_ip_from_fd(int fd) { struct sockaddr_in addr; socklen_t len; static char ip[16]; const char *tmp; g_return_val_if_fail(fd >= 0, NULL); len = sizeof(addr); if (getsockname(fd, (struct sockaddr *) &addr, &len) == -1) { gaim_debug_warning("network", "getsockname: %s\n", strerror(errno)); return NULL; } tmp = inet_ntoa(addr.sin_addr); strncpy(ip, tmp, sizeof(ip)); return ip; } const char * gaim_network_get_local_system_ip(int fd) { struct hostent *host; char localhost[129]; long unsigned add; static char ip[46]; const char *tmp = NULL; if (fd >= 0) tmp = gaim_network_get_local_ip_from_fd(fd); if (tmp) return tmp; if (gethostname(localhost, 128) < 0) return NULL; if ((host = gethostbyname(localhost)) == NULL) return NULL; memcpy(&add, host->h_addr_list[0], 4); add = htonl(add); g_snprintf(ip, 16, "%lu.%lu.%lu.%lu", ((add >> 24) & 255), ((add >> 16) & 255), ((add >> 8) & 255), add & 255); return ip; } const char * gaim_network_get_my_ip(int fd) { const char *ip = NULL; /* Check if the user specified an IP manually */ if (!gaim_prefs_get_bool("/core/network/auto_ip")) { ip = gaim_network_get_public_ip(); if (ip != NULL) return ip; } /* Just fetch the IP of the local system */ return gaim_network_get_local_system_ip(fd); } static int gaim_network_do_listen(unsigned short port) { #if HAVE_GETADDRINFO int listenfd; const int on = 1; struct addrinfo hints, *res, *ressave; char serv[5]; snprintf(serv, sizeof(serv), "%d", port); memset(&hints, 0, sizeof(struct addrinfo)); hints.ai_flags = AI_PASSIVE; hints.ai_family = AF_UNSPEC; hints.ai_socktype = SOCK_STREAM; if (getaddrinfo(NULL /* any IP */, serv, &hints, &res) != 0) { gaim_debug_warning("network", "getaddrinfo: %s\n", strerror(errno)); return -1; } ressave = res; do { listenfd = socket(res->ai_family, res->ai_socktype, res->ai_protocol); if (listenfd < 0) continue; setsockopt(listenfd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); if (bind(listenfd, res->ai_addr, res->ai_addrlen) == 0) break; /* success */ close(listenfd); } while ( (res = res->ai_next) ); if (!res) return -1; freeaddrinfo(ressave); #else int listenfd; const int on = 1; struct sockaddr_in sockin; if ((listenfd = socket(AF_INET, SOCK_STREAM, 0)) < 0) { gaim_debug_warning("network", "socket: %s\n", strerror(errno)); return -1; } if (setsockopt(listenfd, SOL_SOCKET, SO_REUSEADDR, (char *)&on, sizeof(on)) != 0) { gaim_debug_warning("network", "setsockopt: %s\n", strerror(errno)); close(listenfd); return -1; } memset(&sockin, 0, sizeof(struct sockaddr_in)); sockin.sin_family = AF_INET; sockin.sin_port = htons(port); if (bind(listenfd, (struct sockaddr *)&sockin, sizeof(struct sockaddr_in)) != 0) { gaim_debug_warning("network", "bind: %s\n", strerror(errno)); close(listenfd); return -1; } #endif if (listen(listenfd, 4) != 0) { gaim_debug_warning("network", "listen: %s\n", strerror(errno)); close(listenfd); return -1; } fcntl(listenfd, F_SETFL, O_NONBLOCK); gaim_debug_info("network", "Listening on port: %hu\n", gaim_network_get_port_from_fd(listenfd)); return listenfd; } int gaim_network_listen(unsigned short port) { g_return_val_if_fail(port != 0, -1); return gaim_network_do_listen(port); } int gaim_network_listen_range(unsigned short start, unsigned short end) { int ret = -1; if (gaim_prefs_get_bool("/core/network/ports_range_use")) { start = gaim_prefs_get_int("/core/network/ports_range_start"); end = gaim_prefs_get_int("/core/network/ports_range_end"); } else { if (end < start) end = start; } for (; start <= end; start++) { ret = gaim_network_do_listen(start); if (ret >= 0) break; } return ret; } unsigned short gaim_network_get_port_from_fd(int fd) { struct sockaddr_in addr; socklen_t len; g_return_val_if_fail(fd > 0, 0); len = sizeof(addr); if (getsockname(fd, (struct sockaddr *) &addr, &len) == -1) { gaim_debug_warning("network", "getsockname: %s\n", strerror(errno)); return 0; } return ntohs(addr.sin_port); } void gaim_network_init(void) { gaim_prefs_add_none ("/core/network"); gaim_prefs_add_bool ("/core/network/auto_ip", TRUE); gaim_prefs_add_string("/core/network/public_ip", ""); gaim_prefs_add_bool ("/core/network/ports_range_use", FALSE); gaim_prefs_add_int ("/core/network/ports_range_start", 1024); gaim_prefs_add_int ("/core/network/ports_range_end", 2048); }