# HG changeset patch # User Elliott Sales de Andrade # Date 1260773433 0 # Node ID 139aa186e8ccf9c33740d5713c0944df3cd988a2 # Parent bcea7c92d3f13e109d099a77691e430663b64fd6 Don't call purple_xfer_start in msn_xfer_init. purple_xfer_start is called later after the other side accepts, and this second call clobbers the file handle. This file handle is leaked resulting in Pidgin appearing to lock the file stopping Windows from being able to delete it. The changes from darkrain42's branch actually fixed the real file handle leak except for the addition of this one line. Fixes #1643. diff -r bcea7c92d3f1 -r 139aa186e8cc ChangeLog --- a/ChangeLog Mon Dec 14 06:10:28 2009 +0000 +++ b/ChangeLog Mon Dec 14 06:50:33 2009 +0000 @@ -11,6 +11,8 @@ MSN: * File transfer requests will no longer cause a crash if you delete the file before the other side accepts. + * Recieved files will no longer hold an extra lock after completion, meaning + they can be moved or deleted without complaints from your OS. XMPP: * Added support for the SCRAM-SHA-1 SASL mechanism. This is only diff -r bcea7c92d3f1 -r 139aa186e8cc libpurple/protocols/msn/slp.c --- a/libpurple/protocols/msn/slp.c Mon Dec 14 06:10:28 2009 +0000 +++ b/libpurple/protocols/msn/slp.c Mon Dec 14 06:50:33 2009 +0000 @@ -96,8 +96,6 @@ g_free(content); msn_slplink_send_queued_slpmsgs(slpcall->slplink); - - purple_xfer_start(xfer, -1, NULL, 0); } void