# HG changeset patch # User Sadrul Habib Chowdhury # Date 1253986450 0 # Node ID 208fbf27d98739063d4b4850c4afe61dc7ebda01 # Parent a07e46f20644d2b63012f1c56d88378bd6dcdaf4 Fix a couple of possible null-pointer dereferences. Thanks to clang-analyzer (http://clang-analyzer.llvm.org/) diff -r a07e46f20644 -r 208fbf27d987 libpurple/protocols/yahoo/yahoo_filexfer.c --- a/libpurple/protocols/yahoo/yahoo_filexfer.c Sat Sep 26 17:05:37 2009 +0000 +++ b/libpurple/protocols/yahoo/yahoo_filexfer.c Sat Sep 26 17:34:10 2009 +0000 @@ -1363,7 +1363,6 @@ xfer = data; if (!(xd = xfer->data)) { - purple_input_remove(xd->input_event); purple_xfer_cancel_remote(xfer); return; } @@ -1387,7 +1386,6 @@ xfer = data; if (!(xd = xfer->data)) { - purple_input_remove(xd->input_event); purple_xfer_cancel_remote(xfer); return; } @@ -1491,7 +1489,7 @@ char *filename_without_spaces = NULL; xfer = data; - if ( !( (xd = xfer->data) || (listenfd != -1) ) ) { + if (!(xd = xfer->data) || (listenfd == -1)) { purple_debug_warning("yahoo","p2p: error starting server for p2p file transfer\n"); purple_xfer_cancel_remote(xfer); return;