# HG changeset patch # User Gary Kramlich # Date 1128376142 0 # Node ID 24274a79d6b0d347d83daad6a8983510ef4cb829 # Parent 86501c7bce4690b47727a3b3a75051b76e728c0f [gaim-migrate @ 13873] This _seems_ to be taking care of my infinite loop, thanks sadrul for suggesting it :) committer: Tailor Script diff -r 86501c7bce46 -r 24274a79d6b0 src/conversation.c --- a/src/conversation.c Mon Oct 03 21:33:33 2005 +0000 +++ b/src/conversation.c Mon Oct 03 21:49:02 2005 +0000 @@ -341,15 +341,19 @@ gaim_prefs_get_bool("/core/logging/log_chats")); } - ops = conv->ui_ops = default_ops; - if (ops != NULL && ops->create_conversation != NULL) - ops->create_conversation(conv); - conversations = g_list_append(conversations, conv); /* Auto-set the title. */ gaim_conversation_autoset_title(conv); + /* Don't move this.. it needs to be one of the last things done otherwise + * it causes mysterious crashes on my system. + * -- Gary + */ + ops = conv->ui_ops = default_ops; + if (ops != NULL && ops->create_conversation != NULL) + ops->create_conversation(conv); + gaim_signal_emit(gaim_conversations_get_handle(), "conversation-created", conv); diff -r 86501c7bce46 -r 24274a79d6b0 src/gtkconv.c --- a/src/gtkconv.c Mon Oct 03 21:33:33 2005 +0000 +++ b/src/gtkconv.c Mon Oct 03 21:49:02 2005 +0000 @@ -1906,6 +1906,7 @@ if (gtk_check_menu_item_get_active((GtkCheckMenuItem*) m) == FALSE) return; + /* I'm about 99.99% sure we're leaking a conversation here... */ conv = gaim_conversation_new(GAIM_CONV_TYPE_IM, account, name); gtkconv = GAIM_GTK_CONVERSATION(conv);