# HG changeset patch # User Mark Doliner # Date 1212082868 0 # Node ID 2567a386f3a86930c6b57c7f46e3b566302372ff # Parent 073ae152b48167b6c023b9c0343968d9f8b7743c Wow, this isn't used. That will save us either 4 bytes or 8 bytes for each PurpleStatus, depending on whether you're on a 32 bit or 64 bit OS. We create a full set of PurpleStatuses (between 2 and maybe 10, depending on the protocol) for each PurplePresence, and each buddy in your buddylist has a PurplePresence. Assuming you on a 64 bit machine, you have 200 buddies, and you're using a protocol with 8 PurpleStatusTypes, this saves you 12KB of memory. Eh, I guess that's not so bad. Our status system is pretty memory inefficient right now... we tend to duplicate a lot of stuff from the PurpleStatusTypes unneccessarily. I think we can probably get a way with NOT duplicating it and having PurplePresence and PurpleStatus look through to the PurpleStatusTypes as appropriate. But it'll break our API a little, so we can't do it until 3.0.0. diff -r 073ae152b481 -r 2567a386f3a8 libpurple/status.c --- a/libpurple/status.c Thu May 29 15:30:26 2008 +0000 +++ b/libpurple/status.c Thu May 29 17:41:08 2008 +0000 @@ -107,8 +107,6 @@ PurpleStatusType *type; PurplePresence *presence; - const char *title; - gboolean active; /*