# HG changeset patch # User Mark Doliner # Date 1235636064 0 # Node ID 27e6ab4ff5548f1aef7eab511035401d4af9e144 # Parent fc615861c88c25b396390608bb55610302f2770b This should fix a sporadic crash? The behavior before was clearly wrong-- there's no need to check that body != NULL twice. This behavior should be better... but this probably shouldn't be a g_return(), since we don't control the data sent to us by the server it shouldn't be considered a programming error if they fail to send us the "Completed" key diff -r fc615861c88c -r 27e6ab4ff554 libpurple/protocols/myspace/myspace.c --- a/libpurple/protocols/myspace/myspace.c Thu Feb 26 06:03:37 2009 +0000 +++ b/libpurple/protocols/myspace/myspace.c Thu Feb 26 08:14:24 2009 +0000 @@ -3112,8 +3112,8 @@ body = msim_msg_get_dictionary(reply, "body"); g_return_if_fail(body != NULL); completed = msim_msg_get_string(body, "Completed"); - g_return_if_fail(body != NULL); msim_msg_free(body); + g_return_if_fail(completed != NULL); if (!g_str_equal(completed, "True")) { purple_debug_info("msim_import_friends_cb",