# HG changeset patch # User Will Thompson # Date 1191942228 0 # Node ID 38d7c849d444ac48247d7248756f4192851727dd # Parent efa448405f3d98f1507db0d26667d3d2e12bbf44 datallah pointed out that using g_return_if_fail() is preferable to g_assert()ing. diff -r efa448405f3d -r 38d7c849d444 libpurple/connection.c --- a/libpurple/connection.c Tue Oct 09 13:42:15 2007 +0000 +++ b/libpurple/connection.c Tue Oct 09 15:03:48 2007 +0000 @@ -502,7 +502,7 @@ PurpleConnectionUiOps *ops; g_return_if_fail(gc != NULL); - g_assert (reason < PURPLE_NUM_REASONS); + g_return_if_fail(reason < PURPLE_NUM_REASONS); if (description == NULL) { purple_debug_error("connection", "purple_connection_error_reason: check `description != NULL' failed\n"); @@ -575,6 +575,8 @@ case PURPLE_REASON_INVALID_SETTINGS: case PURPLE_REASON_OTHER_ERROR: return TRUE; + default: + g_return_val_if_reached(TRUE); } }