# HG changeset patch # User Daniel Atallah # Date 1288119176 0 # Node ID 3fad1d9e0bc3aa8f2a0c266a93fef5ff713f74f1 # Parent 7a4f51a1e1562efda0fbd422de8053c4ddcb09d9 Quote the path for the windows "run at startup" registry key. The only reason it ever worked like it was is that MS apparently has some wacky fallbacks that makes it find stuff in the Program Files folder when it sees a directory called "Program". Thanks to Christian Lange for noticing and tracking down the problem. Fixes #12781 diff -r 7a4f51a1e156 -r 3fad1d9e0bc3 pidgin/plugins/win32/winprefs/winprefs.c --- a/pidgin/plugins/win32/winprefs/winprefs.c Mon Oct 25 22:43:30 2010 +0000 +++ b/pidgin/plugins/win32/winprefs/winprefs.c Tue Oct 26 18:52:56 2010 +0000 @@ -193,7 +193,7 @@ char *runval = NULL; if(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(w))) - runval = g_strdup_printf("%s" G_DIR_SEPARATOR_S "pidgin.exe", wpurple_install_dir()); + runval = g_strdup_printf("\"%s" G_DIR_SEPARATOR_S "pidgin.exe\"", wpurple_install_dir()); if(!wpurple_write_reg_string(HKEY_CURRENT_USER, RUNKEY, "Pidgin", runval) /* For Win98 */ @@ -267,15 +267,16 @@ } static GtkWidget* get_config_frame(PurplePlugin *plugin) { - GtkWidget *ret; - GtkWidget *vbox; - GtkWidget *button; + GtkWidget *ret, *vbox, *button, *language_sel; char *run_key_val; char *tmp; ret = gtk_vbox_new(FALSE, 18); gtk_container_set_border_width(GTK_CONTAINER(ret), 12); + vbox = pidgin_make_frame(ret, _("Language")); + language_sel = gtk_option_menu_new(); + /* Autostart */ vbox = pidgin_make_frame(ret, _("Startup")); tmp = g_strdup_printf(_("_Start %s on Windows startup"), PIDGIN_NAME);