# HG changeset patch # User Daniel Atallah # Date 1163743937 0 # Node ID 41ced1c9ba2918b6e441d22470305df11bd2814a # Parent dc9ed6c44c48deaaf23cd684f1f545499290b119 [gaim-migrate @ 17767] Ari Pollak traced down a memory leak to the account menuitems not being cleaned up by gtk_container_remove(). It turns out that there is an additional reference somewhere which is preventing the menuitem from being destroyed - deryni tracked it down to gtk_accel_label_set_accel_widget() in gtk_image_menu_item_new_with_label() - we will be reporting the bug to the GTK folks tomorrow. This fixes the leakage; gtk_widget_destroy() is what really should be used in this situation anyway. committer: Tailor Script diff -r dc9ed6c44c48 -r 41ced1c9ba29 gtk/gtkblist.c --- a/gtk/gtkblist.c Fri Nov 17 04:31:21 2006 +0000 +++ b/gtk/gtkblist.c Fri Nov 17 06:12:17 2006 +0000 @@ -5965,8 +5965,7 @@ menuitem = l->data; if (menuitem != gtk_item_factory_get_widget(gtkblist->ift, N_("/Accounts/Add\\/Edit"))) - gtk_container_remove(GTK_CONTAINER(accountmenu), - menuitem); + gtk_widget_destroy(menuitem); } for (accounts = gaim_accounts_get_all(); accounts; accounts = accounts->next) {