# HG changeset patch
# User Mark Doliner <mark@kingant.net>
# Date 1298344758 0
# Node ID 43f75716a23376bf885e265b9e670910738ae39d
# Parent  65999cb4fc40e941bb374d3f1a199a6bfabdfd03
Stop trying to get "gtk-autojoin" as a string from chat rooms in the buddy
list.  This field is a boolean, and has been since at least 2004.  It looks
like it was a boolean even before then, too...
For some reason Nathan added this in revision
d7d95551eb1d08f00bf41b6c742180ffd18bb525 with the comment:
"another one of those horrible hacks that I plan to remove in 6 months or so"

This causes this warning to be logged when right clicking on any chat room
where you have previously had auto-join checked, but it is now unchecked:
"(09:26:22) g_log: purple_blist_node_get_string: assertion purple_value_get_type(value) == PURPLE_TYPE_STRING' failed"

diff -r 65999cb4fc40 -r 43f75716a233 pidgin/gtkblist.c
--- a/pidgin/gtkblist.c	Mon Feb 21 22:57:30 2011 +0000
+++ b/pidgin/gtkblist.c	Tue Feb 22 03:19:18 2011 +0000
@@ -1740,8 +1740,7 @@
 	gboolean autojoin, persistent;
 
 	menu = gtk_menu_new();
-	autojoin = (purple_blist_node_get_bool(node, "gtk-autojoin") ||
-			(purple_blist_node_get_string(node, "gtk-autojoin") != NULL));
+	autojoin = purple_blist_node_get_bool(node, "gtk-autojoin");
 	persistent = purple_blist_node_get_bool(node, "gtk-persistent");
 
 	pidgin_new_item_from_stock(menu, _("_Join"), PIDGIN_STOCK_CHAT,
@@ -7423,9 +7422,7 @@
 			if(chat->account != account)
 				continue;
 
-			if(purple_blist_node_get_bool((PurpleBlistNode*)chat, "gtk-autojoin") ||
-					(purple_blist_node_get_string((PurpleBlistNode*)chat,
-					 "gtk-autojoin") != NULL))
+			if (purple_blist_node_get_bool((PurpleBlistNode*)chat, "gtk-autojoin"))
 				serv_join_chat(gc, chat->components);
 		}
 	}