# HG changeset patch # User Richard Laager # Date 1170653334 0 # Node ID 45d3dd67fa1333dad0edf70159c38ea8406c88dc # Parent 2286aac436947df5c1a8eb28cb0c481305d9f86b With the refactoring I did, it's now possible to reach timestamp_cb_common with conv == NULL. It happens with system logs. I've reworked the code accordingly to avoid an assertion failure. diff -r 2286aac43694 -r 45d3dd67fa13 pidgin/plugins/timestamp_format.c --- a/pidgin/plugins/timestamp_format.c Mon Feb 05 03:37:35 2007 +0000 +++ b/pidgin/plugins/timestamp_format.c Mon Feb 05 05:28:54 2007 +0000 @@ -57,12 +57,11 @@ gboolean force, const char *dates) { - g_return_val_if_fail(conv != NULL, NULL); g_return_val_if_fail(dates != NULL, NULL); if (show_date || !strcmp(dates, "always") || - (gaim_conversation_get_type(conv) == GAIM_CONV_TYPE_CHAT && !strcmp(dates, "chats"))) + (conv != NULL && gaim_conversation_get_type(conv) == GAIM_CONV_TYPE_CHAT && !strcmp(dates, "chats"))) { struct tm *tm = localtime(&t); if (force)