# HG changeset patch # User Will Thompson # Date 1193589796 0 # Node ID 50fa2c5a7029e5227c097e274ab0493625fe4c91 # Parent 71c1f2da4ff24c69226e75a0210285823ba455e9 Deprecate pidgin_blist_update_account_error_state() and PidginBuddyList.connection_errors; update ChangeLog.API. diff -r 71c1f2da4ff2 -r 50fa2c5a7029 ChangeLog.API --- a/ChangeLog.API Sun Oct 28 16:32:37 2007 +0000 +++ b/ChangeLog.API Sun Oct 28 16:43:16 2007 +0000 @@ -32,6 +32,8 @@ to whether automatic reconnection should be attempted after a connection error (rather than checking gc->wants_to_die). + * PurpleConnectionErrorPair, a struct to hold a + PurpleConnectionError and a const char *description. * purple_account_get_current_error() to get the most recent PurpleConnectionError and description (or NULL if the account is happy with life), to allow bits of the UI to know @@ -109,6 +111,10 @@ * purple_request_ok_cancel() * purple_request_yes_no() + * purple_connection_error() + * pidgin_blist_update_account_error_state() + * PidginBuddyList.connection_errors + MSN: * A new independant status type with PURPLE_STATUS_TUNE primitive, and PURPLE_TUNE_ARTIST, PURPLE_TUNE_ALBUM and PURPLE_TUNE_TITLE diff -r 71c1f2da4ff2 -r 50fa2c5a7029 pidgin/gtkblist.h --- a/pidgin/gtkblist.h Sun Oct 28 16:32:37 2007 +0000 +++ b/pidgin/gtkblist.h Sun Oct 28 16:43:16 2007 +0000 @@ -84,7 +84,14 @@ GtkWidget *menutray; /**< The menu tray widget. */ GtkWidget *menutrayicon; /**< The menu tray icon. */ - GHashTable *connection_errors; /**< Caches connection error messages and accounts. */ + /** Caches connection error messages; keys are #PurpleAccount and + * values are non-@c NULL const char *s containing localised + * error messages. (If an account does not have an error, it will not + * appear in the table.) + * @deprecated in favour of purple_account_get_current_error(), which also + * gives you the #PurpleConnectionError value. + */ + GHashTable *connection_errors; guint refresh_timer; /**< The timer for refreshing every 30 seconds */ @@ -339,13 +346,16 @@ void pidgin_append_blist_node_extended_menu(GtkWidget *menu, PurpleBlistNode *node); /** - * Used by the connection API to tell the blist if an account - * has a connection error or no longer has a connection error. + * Was used by the connection API to tell the blist if an account has a + * connection error or no longer has a connection error, but the blist now does + * this itself with the @ref account-error-changed signal. * * @param account The account that either has a connection error * or no longer has a connection error. * @param message The connection error message, or NULL if this * account is no longer in an error state. + * @deprecated There was no good reason for code other than gtkconn to call + * this. */ void pidgin_blist_update_account_error_state(PurpleAccount *account, const char *message);