# HG changeset patch # User Etan Reisner # Date 1231299083 0 # Node ID 7bc52fed6fdb28b1eea88148de2da1bfbb3cdff7 # Parent b97d8001402da754eaa76796239a7453dad62803 Remove a handful of string utility functions from perl, they are generally better handled by perl's built-in functions and at least two of them are reported to crash currently. References #6562 diff -r b97d8001402d -r 7bc52fed6fdb ChangeLog.API --- a/ChangeLog.API Wed Jan 07 02:59:36 2009 +0000 +++ b/ChangeLog.API Wed Jan 07 03:31:23 2009 +0000 @@ -6,6 +6,16 @@ * Purple::PluginPref->get_bounds no longer takes two integer arguments it now returns two integers. + Removed: + * Removed a handful of string-related utility functions that + can generally be better handled with perl's built-in string + functions rather than using pidgin's: + * Purple::Util::strcasereplace + * Purple::Util::strcasestr + * Purple::Util::strreplace + * Purple::Util::str_strip_char + * Purple::Util::chrreplace + version 2.5.3 (12/20/2008): libpurple Changed: diff -r b97d8001402d -r 7bc52fed6fdb libpurple/plugins/perl/common/Util.xs --- a/libpurple/plugins/perl/common/Util.xs Wed Jan 07 02:59:36 2009 +0000 +++ b/libpurple/plugins/perl/common/Util.xs Wed Jan 07 03:31:23 2009 +0000 @@ -99,27 +99,10 @@ const char *program gchar_own * -purple_strcasereplace(string, delimiter, replacement) - const char *string - const char *delimiter - const char *replacement - -const char * -purple_strcasestr(haystack, needle) - const char *haystack - const char *needle - -gchar_own * purple_strdup_withhtml(src) const gchar *src gchar_own * -purple_strreplace(string, delimiter, replacement) - const char *string - const char *delimiter - const char *replacement - -gchar_own * purple_text_strip_mnemonic(in) const char *in @@ -356,10 +339,6 @@ purple_str_size_to_units(size) size_t size -void -purple_str_strip_char(IN_OUT char str, thechar) - char thechar - time_t purple_str_to_time(timestamp, utc = FALSE, tm = NULL, OUTLIST long tz_off, OUTLIST const char *rest) const char *timestamp @@ -512,11 +491,6 @@ const char *artist const char *album -void -purple_util_chrreplace(IN_OUT char string, delimiter, replacement) - char delimiter - char replacement - gchar_own* purple_util_format_song_info(title, artist, album, unused) const char* title