# HG changeset patch # User Richard Laager # Date 1227484887 0 # Node ID 7d07bb66f70b566da4f3d7d4f398dcf5ed0bd723 # Parent 71cf42ff1a6fa1ddcb8f7a830cf5db436821df62 Add a NULL check to fix a crash. Fixes #4516. committer: John Bailey diff -r 71cf42ff1a6f -r 7d07bb66f70b libpurple/protocols/simple/simple.c --- a/libpurple/protocols/simple/simple.c Sun Nov 23 23:16:02 2008 +0000 +++ b/libpurple/protocols/simple/simple.c Mon Nov 24 00:01:27 2008 +0000 @@ -1630,6 +1630,13 @@ cur[0] = '\0'; purple_debug_info("simple", "\n\nreceived - %s\n######\n%s\n#######\n\n", ctime(&currtime), conn->inbuf); msg = sipmsg_parse_header(conn->inbuf); + + if(!msg) { + /* Should we re-use this error message (from lower in the function)? */ + purple_debug_misc("simple", "received a incomplete sip msg: %s\n", conn->inbuf); + return; + } + cur[0] = '\r'; cur += 2; restlen = conn->inbufused - (cur - conn->inbuf);