# HG changeset patch # User Mark Doliner # Date 1229110474 0 # Node ID 85efcade4caa6e1eb3df070e73f91600de524db4 # Parent 2341958e33b58d8ea74094b955e19e68ab18bfb5 Remove unneeded forward declarations. I guess my philosophy is to only forward declare static functions if it's actually needed (like if two static functions call each other, or for other more complex circular dependencies) diff -r 2341958e33b5 -r 85efcade4caa libpurple/protocols/myspace/markup.c --- a/libpurple/protocols/myspace/markup.c Fri Dec 12 19:04:21 2008 +0000 +++ b/libpurple/protocols/myspace/markup.c Fri Dec 12 19:34:34 2008 +0000 @@ -21,20 +21,6 @@ typedef int (*MSIM_XMLNODE_CONVERT)(MsimSession *, xmlnode *, gchar **, gchar **); -/* Internal functions */ - -static guint msim_point_to_purple_size(MsimSession *session, guint point); -static guint msim_purple_size_to_point(MsimSession *session, guint size); -static guint msim_height_to_point(MsimSession *session, guint height); -static guint msim_point_to_height(MsimSession *session, guint point); - -static int msim_markup_tag_to_html(MsimSession *, xmlnode *root, gchar **begin, gchar **end); -static int html_tag_to_msim_markup(MsimSession *, xmlnode *root, gchar **begin, gchar **end); -static gchar *msim_convert_xml(MsimSession *, const gchar *raw, MSIM_XMLNODE_CONVERT f); -static gchar *msim_convert_smileys_to_markup(gchar *before); -static double msim_round(double round); - - /* Globals */ /* The names in in emoticon_names (for ) map to corresponding @@ -118,7 +104,7 @@ /* round is part of C99, but sometimes is unavailable before then. * Based on http://forums.belution.com/en/cpp/000/050/13.shtml */ -double msim_round(double value) +static double msim_round(double value) { if (value < 0) { return -(floor(-value + 0.5));