# HG changeset patch
# User Mark Doliner <mark@kingant.net>
# Date 1172737567 0
# Node ID 8e24d43f529a32f977477171538abb71c6703828
# Parent  12778e2f72820b700be5bbfbd2ff73850846c836
Comments

diff -r 12778e2f7282 -r 8e24d43f529a libpurple/server.c
--- a/libpurple/server.c	Thu Mar 01 08:00:19 2007 +0000
+++ b/libpurple/server.c	Thu Mar 01 08:26:07 2007 +0000
@@ -448,6 +448,7 @@
 	 * been given us by the prpls. So we create temp holders and pass
 	 * those instead. It's basically just to avoid segfaults.
 	 */
+	/* TODO: MAX(message, BUF_LONG) is pretty ugly. */
 	buffy = g_malloc(MAX(strlen(msg) + 1, BUF_LONG));
 	strcpy(buffy, msg);
 	angel = g_strdup(who);
@@ -771,7 +772,7 @@
 	 * data is binary, plugins don't see it. Bitch all you want; i really
 	 * don't want you to be dealing with it.
 	 */
-
+	/* TODO: MAX(message, BUF_LONG) is pretty ugly. */
 	buffy = g_malloc(MAX(strlen(message) + 1, BUF_LONG));
 	strcpy(buffy, message);
 	angel = g_strdup(who);
diff -r 12778e2f7282 -r 8e24d43f529a pidgin/gtkmain.c
--- a/pidgin/gtkmain.c	Thu Mar 01 08:00:19 2007 +0000
+++ b/pidgin/gtkmain.c	Thu Mar 01 08:26:07 2007 +0000
@@ -171,6 +171,11 @@
  * function that can be called by applications to disable forking
  * during initialization.  But it's not in 0.10.0, so we shouldn't
  * use it.
+ *
+ * All of this child process reaping stuff is currently only used for
+ * processes that were forked to play sounds.  It's not needed for
+ * forked DNS child, which have their own waitpid() call.  It might
+ * be wise to move this code into gtksound.c.
  */
 static void
 clean_pid()