# HG changeset patch # User Evan Schoenberg # Date 1208304063 0 # Node ID 919074aa02caafe22fc193e1634fc40f583796c5 # Parent fa7e07c74a5968cbcdd2fbfdd0ed1654448eb144 I've seen intermittent crashes on xmpp file transfers in this code, but I haven't been able to figure out the source. This is some debug logging which will hopefully be illustrative next time someone reports the crash. diff -r fa7e07c74a59 -r 919074aa02ca libpurple/protocols/jabber/si.c --- a/libpurple/protocols/jabber/si.c Tue Apr 15 23:51:03 2008 +0000 +++ b/libpurple/protocols/jabber/si.c Wed Apr 16 00:01:03 2008 +0000 @@ -664,6 +664,9 @@ if(!(jid = xmlnode_get_attrib(streamhost_used, "jid"))) return; + purple_debug_info("jabber", "jabber_si_connect_proxy_cb() will be looking at jsx %p: jsx->streamhosts is %p and jid is %p", + jsx, jsx->streamhosts, jid); + if(!(matched = g_list_find_custom(jsx->streamhosts, jid, jabber_si_compare_jid))) { gchar *my_jid = g_strdup_printf("%s@%s/%s", jsx->js->user->node, @@ -780,6 +783,8 @@ g_snprintf(port, sizeof(port), "%hu", portnum); + purple_debug_info("jabber", "jabber_si_xfer_bytestreams_listen_cb() will be looking at jsx %p: jsx->streamhosts %p and ft_proxy_list[%i] %p", + jsx, jsx->streamhosts, i, ft_proxy_list[i]); if(g_list_find_custom(jsx->streamhosts, ft_proxy_list[i], jabber_si_compare_jid) != NULL) continue; @@ -807,6 +812,8 @@ if (!(sh->jid && sh->host && sh->port > 0)) continue; + purple_debug_info("jabber", "jabber_si_xfer_bytestreams_listen_cb() will be looking at jsx %p: jsx->streamhosts %p and sh->jid %p", + jsx, jsx->streamhosts, sh->jid); if(g_list_find_custom(jsx->streamhosts, sh->jid, jabber_si_compare_jid) != NULL) continue; @@ -969,6 +976,8 @@ g_free(jsx->rxqueue); g_free(jsx); xfer->data = NULL; + + purple_debug_info("jabber", "jabber_si_xfer_free(): freeing jsx %p", jsx); } static void jabber_si_xfer_cancel_send(PurpleXfer *xfer)