# HG changeset patch # User Elliott Sales de Andrade # Date 1267339592 0 # Node ID a0adf0bb19b7e6c077cc8b7588561227e3c61020 # Parent f8a95fdab3bdf034e38525c519ae857feb81dba1 Re-order msg_ack, since purple_xfer_prpl_ready might cancel the transfer and free some pointers. At least, I think that's what valgrind says. diff -r f8a95fdab3bd -r a0adf0bb19b7 libpurple/protocols/msn/slplink.c --- a/libpurple/protocols/msn/slplink.c Sun Feb 28 04:06:46 2010 +0000 +++ b/libpurple/protocols/msn/slplink.c Sun Feb 28 06:46:32 2010 +0000 @@ -307,6 +307,8 @@ slpmsg->offset += msg->msnslp_header.length; + slpmsg->msgs = g_list_remove(slpmsg->msgs, msg); + if (slpmsg->offset < real_size) { if (slpmsg->slpcall->xfer && purple_xfer_get_status(slpmsg->slpcall->xfer) == PURPLE_XFER_STATUS_STARTED) @@ -331,8 +333,6 @@ } } } - - slpmsg->msgs = g_list_remove(slpmsg->msgs, msg); } /* We have received the message nak. */