# HG changeset patch # User William Ehlhardt # Date 1180070545 0 # Node ID a2edef5eb1b1f2dbb7e6c9f82edefeba58cc6302 # Parent 2d2c72f70e8c6d239ebd4a90b16da994afd2d1a2 - Document some weird-looking logic in the GnuTLS plugin. diff -r 2d2c72f70e8c -r a2edef5eb1b1 libpurple/plugins/ssl/ssl-gnutls.c --- a/libpurple/plugins/ssl/ssl-gnutls.c Fri May 25 04:34:43 2007 +0000 +++ b/libpurple/plugins/ssl/ssl-gnutls.c Fri May 25 05:22:25 2007 +0000 @@ -123,6 +123,18 @@ gnutls_data->handshake_handler = purple_input_add(gsc->fd, PURPLE_INPUT_READ, ssl_gnutls_handshake_cb, gsc); + /* Orborde asks: Why are we configuring a callback, then + immediately calling it? + + Answer: gnutls_handshake (up in handshake_cb) needs to be called + once in order to get the ball rolling on the SSL connection. + Once it has done so, only then will the server reply, triggering + the callback. + + Since the logic driving gnutls_handshake is the same with the first + and subsequent calls, we'll just fire the callback immediately to + accomplish this. + */ ssl_gnutls_handshake_cb(gsc, gsc->fd, PURPLE_INPUT_READ); }