# HG changeset patch # User Daniel Atallah # Date 1218687441 0 # Node ID a5bfc59b0c6ed489fca381940a84a0b94fd53efa # Parent abf8ebd4c9e14e7f73106520fe38369ac7950fbd It turns out that setting the window title causes it to stop flashing on win32. This means that every time we recieve a typing notification event for the current tab, we lose notification that we have unread messages. Fortunately, we can avoid this by checking if we actually need to change the title. Fixes #1502 (yay!). diff -r abf8ebd4c9e1 -r a5bfc59b0c6e pidgin/gtkconv.c --- a/pidgin/gtkconv.c Thu Aug 14 03:28:11 2008 +0000 +++ b/pidgin/gtkconv.c Thu Aug 14 04:17:21 2008 +0000 @@ -6604,8 +6604,11 @@ update_typing_icon(gtkconv); gtk_label_set_text(GTK_LABEL(gtkconv->menu_label), title); - if (pidgin_conv_window_is_active_conversation(conv)) - gtk_window_set_title(GTK_WINDOW(win->window), title); + if (pidgin_conv_window_is_active_conversation(conv)) { + const char* current_title = gtk_window_get_title(GTK_WINDOW(win->window)); + if (current_title == NULL || strcmp(current_title, title) != 0) + gtk_window_set_title(GTK_WINDOW(win->window), title); + } g_free(title); }