# HG changeset patch
# User Will Thompson <will.thompson@collabora.co.uk>
# Date 1194107548 0
# Node ID cb9e962d4f7f4f70f70288448599f87c2fe3be58
# Parent  d2bd7eae1c2c7f504ac3b624b4120f32a45aedb6
Fix iterating over accounts_signed_on_elsewhere while doing things that will
cause it to change.

diff -r d2bd7eae1c2c -r cb9e962d4f7f pidgin/gtkblist.c
--- a/pidgin/gtkblist.c	Sat Nov 03 14:35:09 2007 +0000
+++ b/pidgin/gtkblist.c	Sat Nov 03 16:32:28 2007 +0000
@@ -4472,15 +4472,25 @@
 ignore_elsewhere_accounts(PidginBuddyList *gtkblist)
 {
 	PidginBuddyListPrivate *priv = PIDGIN_BUDDY_LIST_GET_PRIVATE(gtkblist);
-	GList *l;
-
-	for (l = priv->accounts_signed_on_elsewhere; l != NULL; l = l->next) {
+	GList *accounts_elsewhere, *l;
+
+	/* priv->accounts_signed_on_elsewhere gets changed in
+	 * update_account_error_state, which is called when
+	 * purple_account_clear_current_error emits account-error-changed. So
+	 * let's take a copy.
+	 *
+	 * (Or maybe we could just use while(priv->accounts_elsewhere) and rely
+	 * on it being ultimately reduced to NULL?  But that sounds fragile.)
+	 */
+	accounts_elsewhere = g_list_copy(priv->accounts_signed_on_elsewhere);
+
+	for (l = accounts_elsewhere; l != NULL; l = l->next)
+	{
 		PurpleAccount *account = l->data;
 		purple_account_clear_current_error(account);
 	}
 
-	g_list_free(priv->accounts_signed_on_elsewhere);
-	priv->accounts_signed_on_elsewhere = NULL;
+	g_list_free(accounts_elsewhere);
 
 	destroy_signed_on_elsewhere_minidialog(priv);
 }