# HG changeset patch # User Elliott Sales de Andrade # Date 1217821593 0 # Node ID d88fd0d9cb5739d33ec7520c54eded99621932c2 # Parent 3c0e7b05714e5add0d2606d59ee6a7207ac1f893 Don't assign this stuff in a loop. diff -r 3c0e7b05714e -r d88fd0d9cb57 libpurple/protocols/msn/slp.c --- a/libpurple/protocols/msn/slp.c Sun Aug 03 23:55:06 2008 +0000 +++ b/libpurple/protocols/msn/slp.c Mon Aug 04 03:46:33 2008 +0000 @@ -814,6 +814,9 @@ if (!purple_account_get_bool(session->account, "custom_smileys", TRUE)) return; + swboard = cmdproc->data; + conv = swboard->conv; + body = msn_message_get_bin_data(msg, &body_len); body_str = g_strndup(body, body_len); @@ -838,10 +841,7 @@ sha1 = msn_object_get_sha1(obj); slplink = msn_session_get_slplink(session, who); - - swboard = cmdproc->data; slplink->swboard = swboard; - conv = swboard->conv; /* If the conversation doesn't exist then this is a custom smiley * used in the first message in a MSN conversation: we need to create