# HG changeset patch # User Evan Schoenberg # Date 1214886379 0 # Node ID e1bddd9c5c88299c0c749ff7d27e311d9409f22c # Parent 47b709962aabcac92f5cef8ff97fa4d279c5edb0 jabber_google_roster_add_deny() and jabber_google_roster_rem_deny() previously recreated the iq, query, and item after inserting group information, nullifying the usefulness of having done so. I don't know of a specific problem which this fixes, as I just noticed it while investigating the "jabber:iq:roster" infinite loop discussed on pidgin-devl and in #5484 diff -r 47b709962aab -r e1bddd9c5c88 libpurple/protocols/jabber/google.c --- a/libpurple/protocols/jabber/google.c Mon Jun 30 22:58:18 2008 +0000 +++ b/libpurple/protocols/jabber/google.c Tue Jul 01 04:26:19 2008 +0000 @@ -314,11 +314,6 @@ buddies = buddies->next; } - iq = jabber_iq_new_query(js, JABBER_IQ_SET, "jabber:iq:roster"); - - query = xmlnode_get_child(iq->node, "query"); - item = xmlnode_new_child(query, "item"); - xmlnode_set_attrib(item, "jid", who); xmlnode_set_attrib(item, "name", b->alias ? b->alias : ""); xmlnode_set_attrib(item, "gr:t", "B"); @@ -385,11 +380,6 @@ buddies = buddies->next; } - iq = jabber_iq_new_query(js, JABBER_IQ_SET, "jabber:iq:roster"); - - query = xmlnode_get_child(iq->node, "query"); - item = xmlnode_new_child(query, "item"); - xmlnode_set_attrib(item, "jid", who); xmlnode_set_attrib(item, "name", b->alias ? b->alias : ""); xmlnode_set_attrib(query, "xmlns:gr", "google:roster");