# HG changeset patch # User Richard Laager # Date 1145986037 0 # Node ID ea77ce998dc7fb9d5d1f94f99e43a0023220086c # Parent 87b027bb1f158d45913dd6f4f3716305673c0aee [gaim-migrate @ 16095] Part of SF Patch #1437836 from Sadrul "1. gaim_privacy_[permit|deny]_remove checks whether the buddy in the list. So it is not necessary to do that before calling these functions. (first block in the patch)" Additionally, it does a gaim_normalize()d UTF-8 compare, which should be better than strcmp(). committer: Tailor Script diff -r 87b027bb1f15 -r ea77ce998dc7 src/protocols/msn/userlist.c --- a/src/protocols/msn/userlist.c Tue Apr 25 17:19:45 2006 +0000 +++ b/src/protocols/msn/userlist.c Tue Apr 25 17:27:17 2006 +0000 @@ -399,26 +399,14 @@ if (list_op & MSN_LIST_AL_OP) { /* These are users who are allowed to see our status. */ - - if (g_slist_find_custom(account->deny, passport, - (GCompareFunc)strcmp)) - { - gaim_privacy_deny_remove(gc->account, passport, TRUE); - } - + gaim_privacy_deny_remove(account, passport, TRUE); gaim_privacy_permit_add(account, passport, TRUE); } if (list_op & MSN_LIST_BL_OP) { /* These are users who are not allowed to see our status. */ - - if (g_slist_find_custom(account->permit, passport, - (GCompareFunc)strcmp)) - { - gaim_privacy_permit_remove(gc->account, passport, TRUE); - } - + gaim_privacy_permit_remove(account, passport, TRUE); gaim_privacy_deny_add(account, passport, TRUE); }