# HG changeset patch # User Mark Doliner # Date 1164697188 0 # Node ID f0ffd80aa1965ea9489289ce2e7c3a8fdaa32917 # Parent d0f5147753dd5bae7829d2ef72c48878cf1640ab [gaim-migrate @ 17834] I don't think these parameters are allowed to be null... it looks like it can cause crashes. See Red Hat bug #217335. Thanks to Nalin Dahyabhai for pin pointing the cause of the crash. http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217335 committer: Tailor Script diff -r d0f5147753dd -r f0ffd80aa196 libgaim/protocols/jabber/auth.c --- a/libgaim/protocols/jabber/auth.c Tue Nov 28 06:37:12 2006 +0000 +++ b/libgaim/protocols/jabber/auth.c Tue Nov 28 06:59:48 2006 +0000 @@ -753,7 +753,9 @@ * should try one more round against it */ if (js->sasl_state != SASL_OK) { - js->sasl_state = sasl_client_step(js->sasl, NULL, 0, NULL, NULL, NULL); + const char *c_out; + unsigned int clen; + js->sasl_state = sasl_client_step(js->sasl, NULL, 0, NULL, &c_out, &clen); if (js->sasl_state != SASL_OK) { /* This should never happen! */ gaim_connection_error(js->gc, _("Invalid response from server."));