# HG changeset patch # User Mark Doliner # Date 1156200658 0 # Node ID f71894e1700d9e1466fcc17b29882a6cb29451be # Parent 06f03f2bc6c639b2fccd7655f369f11a4fc0446b [gaim-migrate @ 16963] Fix a crazy bug that we found at meebo. I'm not sure it affects gtk Gaim in quite the same way, but what was happeing is that the conversation sequence number should be incremented by 1 each time a new conversation is created (whether created by someone else or created by you). However, in one place in Gaim conv_seq was being incremented BEFORE it was used and in another it was being incremented AFTER it was used. This can lead to a sequence number being used twice. committer: Tailor Script diff -r 06f03f2bc6c6 -r f71894e1700d libgaim/protocols/msn/switchboard.c --- a/libgaim/protocols/msn/switchboard.c Mon Aug 21 22:48:19 2006 +0000 +++ b/libgaim/protocols/msn/switchboard.c Mon Aug 21 22:50:58 2006 +0000 @@ -252,8 +252,7 @@ gaim_conversation_destroy(swboard->conv); #endif - cmdproc->session->conv_seq++; - swboard->chat_id = cmdproc->session->conv_seq; + swboard->chat_id = cmdproc->session->conv_seq++; swboard->flag |= MSN_SB_FLAG_IM; swboard->conv = serv_got_joined_chat(account->gc, swboard->chat_id,