# HG changeset patch
# User Mark Doliner <mark@kingant.net>
# Date 1234405985 0
# Node ID fa5987472e007fb203543c3a5a140731ced51372
# Parent  b6bcd024a39382f887d3d8e3031a453e3aead51c
Add a note that we should use hash tables for the permit and deny lists.
I don't think we'll be able to make this change until we break binary
compatibility for 3.0.0.

diff -r b6bcd024a393 -r fa5987472e00 libpurple/account.h
--- a/libpurple/account.h	Tue Feb 10 20:37:51 2009 +0000
+++ b/libpurple/account.h	Thu Feb 12 02:33:05 2009 +0000
@@ -132,6 +132,14 @@
 								/*   to NULL when the account inherits      */
 								/*   proxy settings from global prefs.      */
 
+	/*
+	 * TODO: Supplementing the next two linked lists with hash tables
+	 * should help performance a lot when these lists are long.  This
+	 * matters quite a bit for protocols like MSN, where all your
+	 * buddies are added to your permit list.  Currently we have to
+	 * iterate through the entire list if we want to check if someone
+	 * is permitted or denied.  We should do this for 3.0.0.
+	 */
 	GSList *permit;             /**< Permit list.                           */
 	GSList *deny;               /**< Deny list.                             */
 	int perm_deny;              /**< The permit/deny setting.               */