# HG changeset patch
# User Stu Tomlinson <stu@nosnilmot.com>
# Date 1180809994 0
# Node ID fe5a89474e6d56e29b327df67da2bded240735f2
# Parent  02abb6713cf247b64f8de24f4c76618aefe36b0e
Reverse the smiley list only after reading the whole list of smileys in.
Fixes smileys showing up in a "random" order. Fixes #273

diff -r 02abb6713cf2 -r fe5a89474e6d pidgin/gtkthemes.c
--- a/pidgin/gtkthemes.c	Sat Jun 02 17:38:22 2007 +0000
+++ b/pidgin/gtkthemes.c	Sat Jun 02 18:46:34 2007 +0000
@@ -146,6 +146,9 @@
 				list->next = child;
 			else
 				theme->list = child;
+			/* Reverse the Smiley list since it was built in reverse order for efficiency reasons */
+			if (list != NULL)
+				list->smileys = g_slist_reverse(list->smileys);
 			list = child;
 		} else if (!g_ascii_strncasecmp(i, "Name=", strlen("Name="))) {
 			int len;
@@ -201,8 +204,6 @@
 
 			}
 
-			/* Reverse the Smiley list since it was built in reverse order for efficiency reasons */
-			list->smileys = g_slist_reverse(list->smileys);
 
 			if (!have_used_sfile)
 				g_free(sfile);