# HG changeset patch # User Daniel Atallah # Date 1266511038 0 # Node ID fff648ea95ae33d2202e32f8f6afd56428161439 # Parent aacd0b257060d0843abf0d09c8d28157d22aa91e Minor optimization / incorrect use prevention diff -r aacd0b257060 -r fff648ea95ae libpurple/account.c --- a/libpurple/account.c Thu Feb 18 13:02:16 2010 +0000 +++ b/libpurple/account.c Thu Feb 18 16:37:18 2010 +0000 @@ -2744,11 +2744,12 @@ char *who; g_return_val_if_fail(name != NULL, NULL); + g_return_val_if_fail(protocol_id != NULL, NULL); for (l = purple_accounts_get_all(); l != NULL; l = l->next) { account = (PurpleAccount *)l->data; - if (protocol_id && !purple_strequal(account->protocol_id, protocol_id)) - continue; + if (!purple_strequal(account->protocol_id, protocol_id)) + continue; who = g_strdup(purple_normalize(account, name)); if (purple_strequal(purple_normalize(account, purple_account_get_username(account)), who)) {