Mercurial > pidgin.yaz
changeset 27681:37b668b8d6c1
Fix a crash with the Message Notification plugin and the 'hidden' gtkconv
So I was finally able to reproduce this. "Close IMs immediately" was
disabled and in the Message Notification plugin's settings, everything
is disabled except "[Notify for ]IM windows" and
"Present conversation window".
In my testing, this did not prevent the conversation from re-attaching
when a new message comes on. Fixes #8911.
| author | Paul Aurich <paul@darkrain42.org> |
|---|---|
| date | Sat, 18 Jul 2009 05:08:25 +0000 |
| parents | 4e1eef14b095 |
| children | 386265b369c9 |
| files | ChangeLog pidgin/plugins/notify.c |
| diffstat | 2 files changed, 5 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/ChangeLog Sat Jul 18 04:06:48 2009 +0000 +++ b/ChangeLog Sat Jul 18 05:08:25 2009 +0000 @@ -156,6 +156,8 @@ (Kosta Arvanitis) * When file transfers are complete, the received file name written to the conversation window is now linked to the file. + * Fix a crash when closing a conversation tab that has unread messages + when the Message Notification plugin is loaded. Finch: * The hardware cursor is updated correctly. This will be useful
--- a/pidgin/plugins/notify.c Sat Jul 18 04:06:48 2009 +0000 +++ b/pidgin/plugins/notify.c Sat Jul 18 05:08:25 2009 +0000 @@ -572,6 +572,9 @@ static void handle_present(PurpleConversation *conv) { + if (pidgin_conv_is_hidden(PIDGIN_CONVERSATION(conv))) + return; + purple_conversation_present(conv); }