changeset 24997:3d456ca75ed9

Prevent a crash that can occur while copying the contents of the Debug Window. This ends up masking mismatched tags in the imhtml output, but that is better than a crash. Thanks to Danilo Piazzalunga for figuring out what was happening. Fixes #6089
author Daniel Atallah <daniel.atallah@gmail.com>
date Tue, 27 Jan 2009 03:32:11 +0000
parents a8db457c421a
children f648144bc93d
files pidgin/gtkimhtml.c
diffstat 1 files changed, 5 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/pidgin/gtkimhtml.c	Mon Jan 26 02:39:50 2009 +0000
+++ b/pidgin/gtkimhtml.c	Tue Jan 27 03:32:11 2009 +0000
@@ -5378,12 +5378,14 @@
 						text_tag_data_destroy(tmp);
 				}
 
-				if (tmp == NULL)
-					purple_debug_warning("gtkimhtml", "empty queue, more closing tags than open tags!\n");
-				else {
+				if (tmp != NULL) {
 					g_string_append(str, tmp->end);
 					text_tag_data_destroy(tmp);
 				}
+#if 0 /* This can't be allowed to happen because it causes the iters to be invalidated in the debug window imhtml during text copying */
+				else
+					purple_debug_warning("gtkimhtml", "empty queue, more closing tags than open tags!\n");
+#endif
 
 				while ((tmp = g_queue_pop_head(r))) {
 					g_string_append(str, tmp->start);