changeset 30495:4bcb8e537fc0

I don't know why this function returns a boolean that's never used.
author Elliott Sales de Andrade <qulogic@pidgin.im>
date Fri, 21 May 2010 04:07:02 +0000
parents d7ecbc47f647
children ad6c8747e835
files libpurple/protocols/msn/slp.c
diffstat 1 files changed, 5 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/protocols/msn/slp.c	Fri May 21 04:05:14 2010 +0000
+++ b/libpurple/protocols/msn/slp.c	Fri May 21 04:07:02 2010 +0000
@@ -312,7 +312,7 @@
 	return nonce;
 }
 
-static gboolean
+static void
 msn_slp_process_transresp(MsnSlpCall *slpcall, const char *content)
 {
 	/* A direct connection negotiation response */
@@ -321,16 +321,15 @@
 	char *listening;
 	MsnDirectConn *dc = slpcall->slplink->dc;
 	MsnDirectConnNonceType ntype;
-	gboolean result = FALSE;
 
 	purple_debug_info("msn", "process_transresp\n");
 
 	/* Direct connections are disabled. */
 	if (!purple_account_get_bool(slpcall->slplink->session->account, "direct_connect", TRUE))
-		return FALSE;
+		return;
 
-	g_return_val_if_fail(dc != NULL, FALSE);
-	g_return_val_if_fail(dc->state == DC_STATE_CLOSED, FALSE);
+	g_return_if_fail(dc != NULL);
+	g_return_if_fail(dc->state == DC_STATE_CLOSED);
 
 	bridge = get_token(content, "Bridge: ", "\r\n");
 	nonce = parse_dc_nonce(content, &ntype);
@@ -447,8 +446,6 @@
 			g_free(ip);
 		}
 
-		result = TRUE;
-
 	} else {
 		/*
 		 * Invalid direct connect invitation or
@@ -460,7 +457,7 @@
 	g_free(nonce);
 	g_free(bridge);
 
-	return result;
+	return;
 }
 
 static void