changeset 11701:5d7da4056644

[gaim-migrate @ 13992] SF Patch #1332870, from corfe83 "In gtkimhtml.c, in function gtk_smiley_tree_destroy, in the while loop, we go through the tree and add all the nodes to be deleted to a GSList. However, we add them by appending them to the list, but the order of the list doesn't matter. Because GSList's don't keep track of the last item in the list, this means each step of the loop (when we append) we are incrementing through the whole list. In my tests, on closing the preference box, this loop was gone through more than 1,000 times, and at many stages this list it is appending to is well over 50 elements long. I've changed it to prepend items to the list, which works just the same (although destroying items in the tree in a different order), and is much faster (prepend works in O(1) time, as opposed to O(N) time)." I think the moral of the story is, when order doesn't matter, use g_[s]list_prepend instead of g_[s]list_append. committer: Tailor Script <[e-mail]>

--- a/src/gtkimhtml.c	Thu Oct 20 07:41:50 2005 +0000
+++ b/src/gtkimhtml.c	Thu Oct 20 08:01:03 2005 +0000
@@ -365,7 +365,7 @@
 static void
 gtk_smiley_tree_destroy (GtkSmileyTree *tree)
 {
-	GSList *list = g_slist_append (NULL, tree);
+	GSList *list = g_slist_prepend (NULL, tree);
 
 	while (list) {
 		GtkSmileyTree *t = list->data;
@@ -373,7 +373,7 @@
 		list = g_slist_remove(list, t);
 		if (t && t->values) {
 			for (i = 0; i < t->values->len; i++)
-				list = g_slist_append (list, t->children [i]);
+				list = g_slist_prepend (list, t->children [i]);
 			g_string_free (t->values, TRUE);
 			g_free (t->children);
 		}