Mercurial > pidgin.yaz

changeset 23713:907f5f41e32a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Remove a bunch of *_init() and *_uninit() functions that don't make sense for Perl plugins to call. Plug a couple leaks. Mark a couple functions that need to be fixed.
author Daniel Atallah <daniel.atallah@gmail.com>
date Thu, 07 Aug 2008 03:10:44 +0000
parents af603a54ae5a
children ae3263bfd3f5
files libpurple/plugins/perl/common/Account.xs libpurple/plugins/perl/common/BuddyIcon.xs libpurple/plugins/perl/common/BuddyList.xs libpurple/plugins/perl/common/Cipher.xs libpurple/plugins/perl/common/Connection.xs libpurple/plugins/perl/common/Conversation.xs libpurple/plugins/perl/common/Log.xs libpurple/plugins/perl/common/Network.xs libpurple/plugins/perl/common/Plugin.xs libpurple/plugins/perl/common/Pounce.xs libpurple/plugins/perl/common/Prefs.xs libpurple/plugins/perl/common/Privacy.xs libpurple/plugins/perl/common/Proxy.xs libpurple/plugins/perl/common/SSLConn.xs libpurple/plugins/perl/common/SavedStatuses.xs libpurple/plugins/perl/common/Sound.xs libpurple/plugins/perl/common/Status.xs libpurple/plugins/perl/common/Util.xs
diffstat 18 files changed, 4 insertions(+), 91 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/plugins/perl/common/Account.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Account.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -319,9 +319,3 @@
 
 Purple::Handle
 purple_accounts_get_handle()
-
-void
-purple_accounts_init()
-
-void
-purple_accounts_uninit()
--- a/libpurple/plugins/perl/common/BuddyIcon.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/BuddyIcon.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -45,7 +45,7 @@
 	int *width
 	int *height
 
-char *
+gchar_own *
 purple_buddy_icon_get_full_path(icon);
 	Purple::Buddy::Icon icon
 
@@ -69,8 +69,3 @@
 Purple::Handle
 purple_buddy_icons_get_handle();
 
-void
-purple_buddy_icons_init();
-
-void
-purple_buddy_icons_uninit()
--- a/libpurple/plugins/perl/common/BuddyList.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/BuddyList.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -259,12 +259,6 @@
 Purple::BuddyList::Node
 purple_blist_get_root()
 
-void
-purple_blist_init()
-
-void
-purple_blist_uninit()
-
 MODULE = Purple::BuddyList  PACKAGE = Purple::BuddyList::Node  PREFIX = purple_blist_node_
 PROTOTYPES: ENABLE
 
--- a/libpurple/plugins/perl/common/Cipher.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Cipher.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -128,12 +128,6 @@
 Purple::Handle
 purple_ciphers_get_handle()
 
-void
-purple_ciphers_init()
-
-void
-purple_ciphers_uninit()
-
 MODULE = Purple::Cipher  PACKAGE = Purple::Cipher::Context  PREFIX = purple_cipher_context_
 PROTOTYPES: ENABLE
 
--- a/libpurple/plugins/perl/common/Connection.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Connection.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -94,11 +94,5 @@
 Purple::Connection::UiOps
 purple_connections_get_ui_ops()
 
-void
-purple_connections_init()
-
-void
-purple_connections_uninit()
-
 Purple::Handle
 purple_connections_get_handle()
--- a/libpurple/plugins/perl/common/Conversation.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Conversation.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -124,12 +124,6 @@
 Purple::Handle
 purple_conversations_get_handle()
 
-void
-purple_conversations_init()
-
-void
-purple_conversations_uninit()
-
 MODULE = Purple::Conversation  PACKAGE = Purple::Conversation  PREFIX = purple_conversation_
 PROTOTYPES: ENABLE
 
--- a/libpurple/plugins/perl/common/Log.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Log.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -100,9 +100,6 @@
 	Purple::Account account
 
 void
-purple_log_init()
-
-void
 purple_log_logger_free(logger)
 	Purple::Log::Logger logger
 
--- a/libpurple/plugins/perl/common/Network.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Network.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -18,9 +18,6 @@
 const char *
 purple_network_get_public_ip()
 
-void
-purple_network_init()
-
 const unsigned char *
 purple_network_ip_atoi(ip)
 	const char *ip
--- a/libpurple/plugins/perl/common/Plugin.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Plugin.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -164,9 +164,3 @@
 
 Purple::Handle
 purple_plugins_get_handle()
-
-void
-purple_plugins_init()
-
-void
-purple_plugins_uninit()
--- a/libpurple/plugins/perl/common/Pounce.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Pounce.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -121,15 +121,9 @@
 Purple::Handle
 purple_pounces_get_handle()
 
-void
-purple_pounces_init()
-
 gboolean
 purple_pounces_load()
 
 void
-purple_pounces_uninit()
-
-void
 purple_pounces_unregister_handler(ui)
 	const char *ui
--- a/libpurple/plugins/perl/common/Prefs.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Prefs.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -119,9 +119,6 @@
 purple_prefs_get_type(name)
 	const char *name
 
-void
-purple_prefs_init()
-
 gboolean
 purple_prefs_load()
 
@@ -192,7 +189,4 @@
 	}
 
 void
-purple_prefs_uninit()
-
-void
 purple_prefs_update_old()
--- a/libpurple/plugins/perl/common/Privacy.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Privacy.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -7,9 +7,6 @@
 purple_privacy_get_ui_ops()
 
 void
-purple_privacy_init()
-
-void
 purple_privacy_set_ui_ops(ops)
 	Purple::Privacy::UiOps ops
 
--- a/libpurple/plugins/perl/common/Proxy.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Proxy.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -24,9 +24,6 @@
 Purple::Handle
 purple_proxy_get_handle()
 
-void
-purple_proxy_init()
-
 MODULE = Purple::Proxy  PACKAGE = Purple::ProxyInfo  PREFIX = purple_proxy_info_
 PROTOTYPES: ENABLE
 
--- a/libpurple/plugins/perl/common/SSLConn.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/SSLConn.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -35,9 +35,6 @@
 Purple::Ssl::Ops
 purple_ssl_get_ops()
 
-void
-purple_ssl_init()
-
 gboolean
 purple_ssl_is_supported()
 
@@ -51,9 +48,6 @@
 purple_ssl_set_ops(ops)
 	Purple::Ssl::Ops ops
 
-void
-purple_ssl_uninit()
-
 size_t
 purple_ssl_write(gsc, buffer, len)
 	Purple::Ssl::Connection gsc
--- a/libpurple/plugins/perl/common/SavedStatuses.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/SavedStatuses.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -150,9 +150,3 @@
 
 Purple::Handle
 purple_savedstatuses_get_handle()
-
-void
-purple_savedstatuses_init()
-
-void
-purple_savedstatuses_uninit()
--- a/libpurple/plugins/perl/common/Sound.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Sound.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -30,9 +30,6 @@
 purple_sound_get_ui_ops()
 
 void
-purple_sound_init()
-
-void
 purple_sound_play_event(event, account)
 	Purple::SoundEventID event
 	Purple::Account account
@@ -45,6 +42,3 @@
 void
 purple_sound_set_ui_ops(ops)
 	Purple::Sound::UiOps ops
-
-void
-purple_sound_uninit()
--- a/libpurple/plugins/perl/common/Status.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Status.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -341,12 +341,6 @@
 	const char *id
 	const char *value
 
-void
-purple_status_init()
-
-void
-purple_status_uninit()
-
 MODULE = Purple::Status  PACKAGE = Purple::StatusType  PREFIX = purple_status_type_
 PROTOTYPES: ENABLE
 
--- a/libpurple/plugins/perl/common/Util.xs	Thu Aug 07 02:48:21 2008 +0000
+++ b/libpurple/plugins/perl/common/Util.xs	Thu Aug 07 03:10:44 2008 +0000
@@ -202,7 +202,7 @@
 purple_utf8_ncr_encode(in)
 	const char* in
 
-gchar*
+gchar_own*
 purple_utf8_salvage(str)
 	const char* str
 
@@ -356,6 +356,7 @@
 purple_str_size_to_units(size)
 	size_t size
 
+#TODO: Fix this to handle str being modified in-place
 void
 purple_str_strip_char(str, thechar)
 	char *str
@@ -513,6 +514,7 @@
 	const char *artist
 	const char *album
 
+#TODO: Fix this to handle str being modified in-place
 void
 purple_util_chrreplace(string, delimiter, replacement)
 	char* string