changeset 14474:adcdf5e04128

[gaim-migrate @ 17190] Comment change committer: Tailor Script <tailor@pidgin.im>
author Mark Doliner <mark@kingant.net>
date Fri, 08 Sep 2006 06:17:59 +0000
parents 0c6e1fecb7a0
children feedb7828791
files libgaim/proxy.c
diffstat 1 files changed, 6 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/libgaim/proxy.c	Fri Sep 08 06:07:19 2006 +0000
+++ b/libgaim/proxy.c	Fri Sep 08 06:17:59 2006 +0000
@@ -888,11 +888,12 @@
 			else
 			{
 				/*
-				 * TODO: Uh, is this a good idea?  For something like
-				 *       oscar, for example, we end up sending binary
-				 *       oscar protocol data to the proxy server, which
-				 *       has no idea what we're talking about, since
-				 *       the proxy server is expecting an HTTP request.
+				 * If we're trying to connect to something running on
+				 * port 80 then we assume the traffic using this
+				 * connection is going to be HTTP traffic.  If it's
+				 * not then this will fail (uglily).  But it's good
+				 * to avoid using the CONNECT method because it's
+				 * not always allowed.
 				 */
 				gaim_debug_info("proxy", "HTTP proxy connection established\n");
 				gaim_proxy_connect_data_connected(connect_data);