Mercurial > pidgin.yaz

changeset 21621:b2aa68cdc8b9

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
I had used memcpy to copy the struct tm to where the caller wants it, but this assumes all callers provide their own allocated struct, which is not necessarily always the case. If callers want to keep the values of this struct tm across multiple calls to purple_str_to_time, they had better copy it themselves. (which is essentially the same as it was before when we were returning the pointer to the struct as returned by localtime(), which is also statically allocated)
author Stu Tomlinson <stu@nosnilmot.com>
date Fri, 23 Nov 2007 19:41:44 +0000
parents 85fc97ffe538
children 1c34b63076df
files libpurple/util.c
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/libpurple/util.c	Thu Nov 22 19:34:50 2007 +0000
+++ b/libpurple/util.c	Fri Nov 23 19:41:44 2007 +0000
@@ -897,7 +897,7 @@
 
 	if (tm != NULL)
 	{
-		memcpy(tm, &t, sizeof(struct tm));
+		*tm = t;
 		tm->tm_isdst = -1;
 		mktime(tm);
 	}